ACK: [PATCH][RESEND] uefirtvariable: add some information for the GetNextVariableName sub-tests

Alex Hung alex.hung at canonical.com
Mon Apr 8 08:31:09 UTC 2013


On 04/08/2013 08:53 AM, Ivan Hu wrote:
> From: IvanHu <ivan.hu at canonical.com>
>
> Add more information for testing the GetNextVarialbeName sub-tests.
>
> Signed-off-by: Ivan Hu <ivan.hu at canonical.com>
> ---
>   src/uefi/uefirtvariable/uefirtvariable.c |    9 ++++++++-
>   1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/src/uefi/uefirtvariable/uefirtvariable.c b/src/uefi/uefirtvariable/uefirtvariable.c
> index c5caa33..50e4e3a 100644
> --- a/src/uefi/uefirtvariable/uefirtvariable.c
> +++ b/src/uefi/uefirtvariable/uefirtvariable.c
> @@ -1165,23 +1165,30 @@ static int uefirtvariable_test2(fwts_framework *fw)
>   {
>   	int ret;
>
> +	fwts_log_info(fw, "The runtime service GetNextVariableName interface function test.");
>   	ret = getnextvariable_test1(fw);
>   	if (ret != FWTS_OK)
>   		return ret;
> +	fwts_passed(fw, "The runtime service GetNextVariableName interface function test passed.");
>
> +	fwts_log_info(fw, "Check the GetNextVariableName returned value of VariableNameSize is equal to the length of VariableName.");
>   	ret = getnextvariable_test2(fw);
>   	if (ret != FWTS_OK)
>   		return ret;
> +	fwts_passed(fw, "Check the GetNextVariableName returned value of VariableNameSize is equal to the length of VariableName passed.");
>
> +	fwts_log_info(fw, "Test GetNextVariableName interface returns unique variables.");
>   	ret = getnextvariable_test3(fw);
>   	if (ret != FWTS_OK)
>   		return ret;
> +	fwts_passed(fw, "Test GetNextVariableName interface returns unique variables passed.");
>
> +	fwts_log_info(fw, "The GetNextVariableName interface conformance tests.");
>   	ret = getnextvariable_test4(fw);
>   	if (ret != FWTS_OK)
>   		return ret;
> +	fwts_passed(fw, "The runtime service GetNextVariableName interface conformance tests passed.");
>
> -	fwts_passed(fw, "UEFI runtime service GetNextVariableName interface test passed.");
>
>   	return FWTS_OK;
>   }
>
Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list