fwts 0.25.07-rc2 review

[Colin Ian King]

On 04/09/12 09:31, Keng-Yu Lin wrote:
> Dear all
>    V0.25.07-rc2 tag is pushed to both fwts and fwts-test git
> repository.

So I tested this out on an updated Quantal box just a minute ago and I'm 
getting random segfaults in the arg-json-0002 and arg-json-0003 tests. 
This is down to the test:

sudo fwts klog --klog=klog.txt --json-data-path=/xxxx/fooo

which now causes the json library to segfault if /xxxx/fooo does not 
exist. Why its now failing is beyond me at the moment.  I've sent a 
patch to the mailing list that works around this.

So, from my point of view, the -rc2 can't be ACK'd.

Apart from that, the other tests seem OK to me.

Colin

>
>    Since this release, fwts is release as a tarball. It is available at
> http://people.canonical.com/~lexical/fwts/
>
>    There are also pre-built debs available for testing:
> http://people.canonical.com/~lexical/fwts-builds/
>
>    fwts-test failure.log is clear.
>
>    * fwts has no change since 0.25.07-rc1
>    * fwts-test changes since 0.25.07-rc1
>      - method-0001: Sync up with the change of thermal return value checking
>      - arg-show-tests-full-0001: Update to sync with the removal of _BFS and _GTS
>
>    With two ACKs the fwts 0.25.07 is ready to go to PPA and then upload
> to Quanta.
>
>    cheers,
> -kengyu
>
>
>