[PATCH 0/3] lib: changes to enabled -Wextra

Colin King colin.king at canonical.com
Thu Oct 25 10:48:28 UTC 2012


From: Colin Ian King <colin.king at canonical.com>

I want to make sure we catch all sorts of subtle coding mistakes
by using -Wextra at least on the fwts library.  To cater for this
I've also added FWTS_UNUSED() to add hints to gcc that some unused
function parameters are intentionally unused (such as in function
callbacks or to keep the fwts_* library functions looking consistent
with the fwts_framework * parameter, even when it's not being used).

Colin Ian King (3):
  lib: fwts: add FWTS_UNUSED() macro for unused func arguments
  lib: fwts_*: use FWTS_UNUSED on unused func args in fwts library
  lib: Makefile.am: enable -Wextra

 src/lib/include/fwts.h           |    2 ++
 src/lib/src/Makefile.am          |    2 +-
 src/lib/src/fwts_acpi_method.c   |    4 ++++
 src/lib/src/fwts_battery.c       |    4 ++++
 src/lib/src/fwts_button.c        |    2 ++
 src/lib/src/fwts_cpu.c           |    4 ++++
 src/lib/src/fwts_dump.c          |    2 ++
 src/lib/src/fwts_framework.c     |    2 ++
 src/lib/src/fwts_hwinfo.c        |    2 ++
 src/lib/src/fwts_interactive.c   |    2 ++
 src/lib/src/fwts_klog.c          |    6 ++++++
 src/lib/src/fwts_log_html.c      |    8 ++++++++
 src/lib/src/fwts_log_json.c      |   11 +++++++++++
 src/lib/src/fwts_log_plaintext.c |    3 +++
 src/lib/src/fwts_log_xml.c       |    7 +++++++
 src/lib/src/fwts_memorymap.c     |    2 ++
 src/lib/src/fwts_summary.c       |    2 ++
 src/lib/src/fwts_uefi.c          |    2 ++
 18 files changed, 66 insertions(+), 1 deletion(-)

-- 
1.7.10.4




More information about the fwts-devel mailing list