[PATCH] acpi: mcfg: Set MCFGMMIONotReserved error to low

Keng-Yu Lin kengyu at canonical.com
Thu Oct 25 07:02:08 UTC 2012


On Thu, Oct 25, 2012 at 1:42 PM, Alex Hung <alex.hung at canonical.com> wrote:
> In PCI Firmware Specification, it claims "If the operating system does not natively
> comprehend reserving the MMCFG region, the MMCFG region must be reserved by firmware."
> However, Linux is an operating system that comprehend MMCFG, and therefore it is not
> a problem for not declaring it.
>
> Signed-off-by: Alex Hung <alex.hung at canonical.com>
> ---
>  src/acpi/mcfg/mcfg.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/acpi/mcfg/mcfg.c b/src/acpi/mcfg/mcfg.c
> index 9dfd9fd..878c0f1 100644
> --- a/src/acpi/mcfg/mcfg.c
> +++ b/src/acpi/mcfg/mcfg.c
> @@ -200,7 +200,7 @@ static int mcfg_test1(fwts_framework *fw)
>                 if ((memory_map_list != NULL) &&
>                     (!fwts_memory_map_is_reserved(memory_map_list, config->base_address))) {
>
> -                       fwts_failed(fw, LOG_LEVEL_MEDIUM, "MCFGMMIONotReserved",
> +                       fwts_failed(fw, LOG_LEVEL_LOW, "MCFGMMIONotReserved",
>                                 "MCFG mmio config space at 0x%" PRIx64
>                                 " is not reserved in the memory map table",
>                                 config->base_address);
> --
> 1.7.9.5
>
Acked-by: Keng-Yu Lin <kengyu at canonical.com>



More information about the fwts-devel mailing list