[PATCH 21/26] cpu: maxfreq: remove redundant init and deinit functions

Keng-Yu Lin kengyu at canonical.com
Wed Oct 17 07:56:11 UTC 2012


On Mon, Oct 15, 2012 at 4:32 AM, Colin King <colin.king at canonical.com> wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> We can remove redundant maxfreq_init and maxfreq_deinit
> functions - if they are null then we don't need to call
> them at start and completion of the test.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  src/cpu/maxfreq/maxfreq.c |   12 ------------
>  1 file changed, 12 deletions(-)
>
> diff --git a/src/cpu/maxfreq/maxfreq.c b/src/cpu/maxfreq/maxfreq.c
> index 16a8732..bc70fc9 100644
> --- a/src/cpu/maxfreq/maxfreq.c
> +++ b/src/cpu/maxfreq/maxfreq.c
> @@ -28,16 +28,6 @@
>  #define CPU_FREQ_PATH  "/sys/devices/system/cpu"
>  #define CPU_INFO_PATH  "/proc/cpuinfo"
>
> -static int maxfreq_init(fwts_framework *fw)
> -{
> -       return FWTS_OK;
> -}
> -
> -static int maxfreq_deinit(fwts_framework *fw)
> -{
> -       return FWTS_OK;
> -}
> -
>  typedef struct {
>         int cpu;
>         int speed;
> @@ -199,8 +189,6 @@ static fwts_framework_minor_test maxfreq_tests[] = {
>
>  static fwts_framework_ops maxfreq_ops = {
>         .description = "Check max CPU frequencies against max scaling frequency.",
> -       .init        = maxfreq_init,
> -       .deinit      = maxfreq_deinit,
>         .minor_tests = maxfreq_tests
>  };
>
> --
> 1.7.10.4
>
Acked-by: Keng-Yu Lin <kengyu at canonical.com>



More information about the fwts-devel mailing list