ACK: [PATCH 08/26] lib: fwts_framework: remove fw parameter from fwts_framework_skip_test_parse

Alex Hung alex.hung at canonical.com
Mon Oct 15 03:21:57 UTC 2012


On 10/15/2012 04:32 AM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> We don't need the fw parameter in fwts_framework_skip_test_parse
> so remove it.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>   src/lib/src/fwts_framework.c |    6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/lib/src/fwts_framework.c b/src/lib/src/fwts_framework.c
> index 075a652..1a7313d 100644
> --- a/src/lib/src/fwts_framework.c
> +++ b/src/lib/src/fwts_framework.c
> @@ -818,7 +818,7 @@ static fwts_framework_test *fwts_framework_skip_test(fwts_list *tests_to_skip, f
>    *  fwts_framework_skip_test_parse()
>    *	parse optarg of comma separated list of tests to skip
>    */
> -static int fwts_framework_skip_test_parse(fwts_framework *fw, const char *arg, fwts_list *tests_to_skip)
> +static int fwts_framework_skip_test_parse(const char *arg, fwts_list *tests_to_skip)
>   {
>   	char *str;
>   	char *token;
> @@ -951,7 +951,7 @@ int fwts_framework_options_handler(fwts_framework *fw, int argc, char * const ar
>   					| FWTS_FLAG_SHOW_PROGRESS_DIALOG;
>   			break;
>   		case 23: /* --skip-test */
> -			if (fwts_framework_skip_test_parse(fw, optarg, &tests_to_skip) != FWTS_OK)
> +			if (fwts_framework_skip_test_parse(optarg, &tests_to_skip) != FWTS_OK)
>   				return FWTS_COMPLETE;
>   			break;
>   		case 24: /* --quiet */
> @@ -1048,7 +1048,7 @@ int fwts_framework_options_handler(fwts_framework *fw, int argc, char * const ar
>   		fw->flags |= FWTS_FLAG_SHOW_TESTS;
>   		break;
>   	case 'S': /* --skip-test */
> -		if (fwts_framework_skip_test_parse(fw, optarg, &tests_to_skip) != FWTS_OK)
> +		if (fwts_framework_skip_test_parse(optarg, &tests_to_skip) != FWTS_OK)
>   			return FWTS_COMPLETE;
>   		break;
>   	case 't': /* --table-path */
>

Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list