ACK: [PATCH 06/26] lib: fwts_framework: remove redundant fw parameter from fwts_framework_show_tests_brief

Alex Hung alex.hung at canonical.com
Mon Oct 15 03:19:23 UTC 2012


On 10/15/2012 04:31 AM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> The framework parameter is not required in fwts_framework_show_tests_brief
> so remove it.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>   src/lib/src/fwts_framework.c |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/lib/src/fwts_framework.c b/src/lib/src/fwts_framework.c
> index 3be2c3e..8637882 100644
> --- a/src/lib/src/fwts_framework.c
> +++ b/src/lib/src/fwts_framework.c
> @@ -178,7 +178,7 @@ int fwts_framework_compare_test_name(void *data1, void *data2)
>    *  fwts_framework_show_tests()
>    *	dump out registered tests in brief form
>    */
> -static void fwts_framework_show_tests_brief(fwts_framework *fw)
> +static void fwts_framework_show_tests_brief(void)
>   {
>   	fwts_list sorted;
>   	fwts_list_link *item;
> @@ -1173,7 +1173,7 @@ int fwts_framework_args(const int argc, char **argv)
>
>   		if ((test = fwts_framework_test_find(fw, argv[i])) == NULL) {
>   			fprintf(stderr, "No such test '%s', available tests:\n",argv[i]);
> -			fwts_framework_show_tests_brief(fw);
> +			fwts_framework_show_tests_brief();
>   			ret = FWTS_ERROR;
>   			goto tidy;
>   		}
>

Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list