ACK: [PATCH 05/26] lib: fwts_framework: remove redundant parameter from fwts_framework_run_test

Alex Hung alex.hung at canonical.com
Mon Oct 15 03:06:11 UTC 2012


On 10/15/2012 04:31 AM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> Remove redundant parameter num_tests from fwts_framework_run_test, it is
> no longer required, legacy cruft.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>   src/lib/src/fwts_framework.c |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/lib/src/fwts_framework.c b/src/lib/src/fwts_framework.c
> index aa26d4b..3be2c3e 100644
> --- a/src/lib/src/fwts_framework.c
> +++ b/src/lib/src/fwts_framework.c
> @@ -464,7 +464,7 @@ static int fwts_framework_total_summary(fwts_framework *fw)
>   	return FWTS_OK;
>   }
>
> -static int fwts_framework_run_test(fwts_framework *fw, const int num_tests, fwts_framework_test *test)
> +static int fwts_framework_run_test(fwts_framework *fw, fwts_framework_test *test)
>   {
>   	fwts_framework_minor_test *minor_test;
>   	int ret;
> @@ -627,7 +627,7 @@ static void fwts_framework_tests_run(fwts_framework *fw, fwts_list *tests_to_run
>
>   	fwts_list_foreach(item, tests_to_run) {
>   		fwts_framework_test *test = fwts_list_data(fwts_framework_test *, item);
> -		fwts_framework_run_test(fw, fwts_list_len(tests_to_run), test);
> +		fwts_framework_run_test(fw, test);
>   		fw->current_major_test_num++;
>   	}
>   }
>
Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list