[PATCH 26/26] lib: fwts_alloc: use ptrdiff_t to ensure non-mixed type comparison
Colin King
colin.king at canonical.com
Sun Oct 14 20:32:18 UTC 2012
From: Colin Ian King <colin.king at canonical.com>
When comparing difference of two pointers we should compare to
a ptrdiff_t to avoid any messy non-mixed type comparisons.
Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
src/lib/src/fwts_alloc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/lib/src/fwts_alloc.c b/src/lib/src/fwts_alloc.c
index 4495ad4..5c61478 100644
--- a/src/lib/src/fwts_alloc.c
+++ b/src/lib/src/fwts_alloc.c
@@ -20,6 +20,7 @@
#include <string.h>
#include <stdio.h>
#include <unistd.h>
+#include <stddef.h>
#include "fwts_alloc.h"
@@ -75,7 +76,7 @@ static void *fwts_low_mmap(const size_t requested_size)
if ((last_addr_end != NULL) &&
(last_addr_end < (void*)LIMIT_2GB)) {
- if ((addr_start - last_addr_end) > requested_size) {
+ if ((addr_start - last_addr_end) > (ptrdiff_t)requested_size) {
void *addr = last_addr_end;
ret = mmap(addr, requested_size, PROT_READ | PROT_WRITE,
MAP_PRIVATE | MAP_FIXED | MAP_ANONYMOUS, -1, 0);
--
1.7.10.4
More information about the fwts-devel
mailing list