[PATCH 1/3] lib: fwts_test: calloc being called with args swapped

Keng-Yu Lin kengyu at canonical.com
Thu Nov 22 06:07:36 UTC 2012


On Fri, Nov 16, 2012 at 4:32 PM, Colin King <colin.king at canonical.com> wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> Fix calloc call in fwts_list_append, args were swapped which
> still works but we should fix this so we are allocating one
> fwts_list_link rather than sizeof(fwts_list_link) number of
> bytes.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  src/lib/src/fwts_list.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/lib/src/fwts_list.c b/src/lib/src/fwts_list.c
> index e26b2cb..935910b 100644
> --- a/src/lib/src/fwts_list.c
> +++ b/src/lib/src/fwts_list.c
> @@ -121,7 +121,7 @@ fwts_list_link *fwts_list_append(fwts_list *list, void *data)
>         if (list == NULL)
>                 return NULL;
>
> -       if ((link = calloc(sizeof(fwts_list_link),1)) == NULL)
> +       if ((link = calloc(1,sizeof(fwts_list_link))) == NULL)
>                 return NULL;
>
>         link->data = data;
> --
> 1.7.10.4
>
Acked-by: Keng-Yu Lin <kengyu at canonical.com>



More information about the fwts-devel mailing list