[PATCH 2/2] pci: maxreadreq: ensure we don't overflow with strncpy
Colin King
colin.king at canonical.com
Tue Nov 6 16:19:30 UTC 2012
From: Colin Ian King <colin.king at canonical.com>
Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
src/pci/maxreadreq/maxreadreq.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/pci/maxreadreq/maxreadreq.c b/src/pci/maxreadreq/maxreadreq.c
index a570b37..e5ace46 100644
--- a/src/pci/maxreadreq/maxreadreq.c
+++ b/src/pci/maxreadreq/maxreadreq.c
@@ -88,7 +88,8 @@ static int maxreadreq_test1(fwts_framework *fw)
break;
}
snprintf(current_device, sizeof(current_device), "pci://00:%s", line);
- strncpy(current_type, line+8, 511);
+ strncpy(current_type, line+8, sizeof(current_type)-1);
+ current_type[sizeof(current_type)-1] = '\0';
c = strchr(current_type, ':');
if (c)
*c='\0';
--
1.7.10.4
More information about the fwts-devel
mailing list