NACK: [PATCH 00/12] fwts lib: don't use strcpy and strcat

[Colin Ian King]

On 04/11/12 22:19, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> To ensure we don't get buffer overruns use strncpy and strncat
> in the fwts library.
>
> Colin Ian King (12):
>    lib: fwts_tag: use strncpy instead of strcpy
>    lib: fwts_stringextras: use strncpy, strncat instead of strcpy, strcat
>    lib: fwts_args: use strncpy, strncat instead of strcpy, strcat
>    lib: fwts_log: use strncpy, strncat instead of strcpy, strcat
>    lib: fwts_klog: use strncpy instead of strcpy
>    lib: fwts_battery: use strncpy instead of strcpy
>    lib: fwts_acpi_tables: use strncpy instead of strcpy
>    lib: fwts_acpi_acpid: use strncpy instead of strcpy
>    lib: fwts_acpica: use strncpy, strncat instead of strcpy, strcat
>    lib: fwts_tagc: use strncat instead of strcat
>    lib: fwts_log_html: use strncat instead of strcat
>    lib: fwts_framework: use strncat instead of strcat
>
>   src/acpi/battery/battery.c      |    2 +-
>   src/acpica/fwts_acpica.c        |    4 ++--
>   src/lib/include/fwts_battery.h  |    2 +-
>   src/lib/src/fwts_acpi_tables.c  |   23 ++++++++++++++---------
>   src/lib/src/fwts_acpid.c        |    2 +-
>   src/lib/src/fwts_args.c         |   17 +++++++++--------
>   src/lib/src/fwts_battery.c      |   17 ++++++++++-------
>   src/lib/src/fwts_framework.c    |    4 ++--
>   src/lib/src/fwts_klog.c         |    2 +-
>   src/lib/src/fwts_log.c          |   21 +++++++++++----------
>   src/lib/src/fwts_log_html.c     |    2 +-
>   src/lib/src/fwts_stringextras.c |   10 ++++++----
>   src/lib/src/fwts_tag.c          |    6 +++---
>   13 files changed, 62 insertions(+), 50 deletions(-)
>
NACK on these, I'll send the correct fixes out next week.

Colin