[PATCH 3/3] acpi: wmi: use snprintf to be safe

Keng-Yü Lin kengyu at canonical.com
Mon Mar 5 07:54:58 UTC 2012


On Fri, Mar 2, 2012 at 5:10 PM, Colin King <colin.king at canonical.com> wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  src/acpi/wmi/wmi.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/acpi/wmi/wmi.c b/src/acpi/wmi/wmi.c
> index 8190e17..de353c6 100644
> --- a/src/acpi/wmi/wmi.c
> +++ b/src/acpi/wmi/wmi.c
> @@ -348,7 +348,7 @@ static int wmi_SSDT(fwts_framework *fw)
>
>        for (i=0; i < 16; i++) {
>                char buffer[10];
> -               sprintf(buffer,"SSDT%d", i+1);
> +               snprintf(buffer, sizeof(buffer), "SSDT%d", i+1);
>
>                ret = wmi_table(fw, "SSDT", i, buffer, &result);
>                if (ret == FWTS_NO_TABLE) {
> --
> 1.7.9
>
Acked-by: Keng-Yu Lin <kengyu at canonical.com>




More information about the fwts-devel mailing list