[PATCH] live-image/fwts-frontend-text: use cp versus ln as symbolic links are not supported on fat file systems
Chris Van Hoof
vanhoof at canonical.com
Mon Jul 9 16:44:38 UTC 2012
On 07/08/2012 07:32 AM, Colin Ian King wrote:
> Signed-off-by: Chris Van Hoof <vanhoof at canonical.com>
> ---
> live-image/fwts-frontend-text | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/live-image/fwts-frontend-text b/live-image/fwts-frontend-text
> index 932c068..8315d47 100755
> --- a/live-image/fwts-frontend-text
> +++ b/live-image/fwts-frontend-text
> @@ -197,7 +197,7 @@ done_tests_finish()
> {
> if [ -n "${CASPER_DETECTED:+x}" ]; then
> cd $WORK_DIR
> - ln -sf ./results.html ../../results.html
> + cp ./results.html ../../results.html
> else
> ln -sf $WORK_DIR/results.html /fwts/results.html
> fi
"""
Is it better to mv the file rather than cp it? If it makes no real
difference, then I'm OK with this fix.
Colin
"""
I figured it'd be best to preserve all the data and only copy the latest
to the top-level work dir, but I do see your point, a full run from my
x220 yields a 460K results.html file, which could quickly consume the
10mb snapshot file we use to save the data in.
Anyone else have an opinion? We could leave the existing plaintext data
in place and always move the html to save space for multiple runs?
--chris
More information about the fwts-devel
mailing list