[PATCH] acpi: s3: suspend/resume failures should be HIGH failures

IvanHu ivan.hu at canonical.com
Mon Jul 2 10:33:51 UTC 2012


On 06/28/2012 06:44 PM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>   src/acpi/s3/s3.c |    6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/acpi/s3/s3.c b/src/acpi/s3/s3.c
> index a666033..76bec19 100644
> --- a/src/acpi/s3/s3.c
> +++ b/src/acpi/s3/s3.c
> @@ -165,19 +165,19 @@ static int s3_do_suspend_resume(fwts_framework *fw,
>   	/* Add in error check for pm-suspend status */
>   	if ((status > 0) && (status < 128)) {
>   		(*pm_errors)++;
> -		fwts_failed(fw, LOG_LEVEL_MEDIUM, "PMActionFailedPreS3",
> +		fwts_failed(fw, LOG_LEVEL_HIGH, "PMActionFailedPreS3",
>   			"pm-action failed before trying to put the system "
>   			"in the requested power saving state.");
>   		fwts_tag_failed(fw, FWTS_TAG_POWER_MANAGEMENT);
>   	} else if (status == 128) {
>   		(*pm_errors)++;
> -		fwts_failed(fw, LOG_LEVEL_MEDIUM, "PMActionPowerStateS3",
> +		fwts_failed(fw, LOG_LEVEL_HIGH, "PMActionPowerStateS3",
>   			"pm-action tried to put the machine in the requested "
>   			"power state but failed.");
>   		fwts_tag_failed(fw, FWTS_TAG_POWER_MANAGEMENT);
>   	} else if (status > 128) {
>   		(*pm_errors)++;
> -		fwts_failed(fw, LOG_LEVEL_MEDIUM, "PMActionFailedS3",
> +		fwts_failed(fw, LOG_LEVEL_HIGH, "PMActionFailedS3",
>   			"pm-action encountered an error and also failed to "
>   			"enter the requested power saving state.");
>   		fwts_tag_failed(fw, FWTS_TAG_POWER_MANAGEMENT);
>


Acked-by: Ivan Hu<ivan.hu at canonical.com>




More information about the fwts-devel mailing list