[PATCH] Sanity check for MSR_IA32_ENERGY_PERF_BIAS messages.

Keng-Yü Lin kengyu at canonical.com
Wed Jan 18 08:10:40 UTC 2012


On Tue, Jan 17, 2012 at 3:38 PM, Alex Hung <alex.hung at canonical.com> wrote:
> On 01/04/2012 02:55 AM, Colin King wrote:
>>
>> From: Colin Ian King<colin.king at canonical.com>
>>
>> Since commit abe48b108247e9b90b4c6739662a2e5c765ed114 the kernel has
>> been able to detect if the MSR_IA32_ENERGY_PERF_BIAS was set incorrectly
>> by the firmware.  We may as well use this information to catch any
>> bad MSR_IA32_ENERGY_PERF_BIAS defaults.
>>
>> Signed-off-by: Colin Ian King<colin.king at canonical.com>
>> ---
>>  data/klog.json |    7 +++++++
>>  1 files changed, 7 insertions(+), 0 deletions(-)
>>
>> diff --git a/data/klog.json b/data/klog.json
>> index 4d66a61..4598754 100644
>> --- a/data/klog.json
>> +++ b/data/klog.json
>> @@ -69,6 +69,13 @@
>>   [
>>    {
>>     "compare_mode": "regex",
>> +   "log_level": "LOG_LEVEL_HIGH",
>> +   "tag": "FWTS_TAG_BIOS",
>> +   "pattern": "ENERGY_PERF_BIAS.*Set to 'normal'.* was 'performance'",
>> +   "advice": "The MSR_IA32_ENERGY_PERF_BIAS was initialized incorrectly
>> and was defaulted to a high performance bias setting.  The kernel has
>> detected this and changed it down to a 'normal' bias setting.  The BIOS
>> vendor should be informed that the MSR is not defaulted to the normal bias
>> setting."
>> +  },
>> +  {
>> +   "compare_mode": "regex",
>>     "log_level": "LOG_LEVEL_CRITICAL",
>>     "tag": "FWTS_TAG_ACPI",
>>     "pattern": "pnp.*can't evaluate _CRS: 12311",
>
> Acked-by: Alex Hung <alex.hung at canonical.com>
>
>

applied, thanks for the patch.




More information about the fwts-devel mailing list