[PATCH] bios: mtrr: remove mtrr_test4 because we're removed FWTS_TEST_VGA_REGION

Keng-Yu Lin kengyu at canonical.com
Mon Dec 17 06:38:16 UTC 2012


On Fri, Dec 7, 2012 at 10:28 PM, Colin King <colin.king at canonical.com> wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> An earlier patch removed FWTS_TEST_VGA_REGION but I forgot to also
> remove mtrr_test4.  Remove this unwanted and broken old test.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  src/bios/mtrr/mtrr.c | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/src/bios/mtrr/mtrr.c b/src/bios/mtrr/mtrr.c
> index 285d284..18d542b 100644
> --- a/src/bios/mtrr/mtrr.c
> +++ b/src/bios/mtrr/mtrr.c
> @@ -505,20 +505,10 @@ static int mtrr_test3(fwts_framework *fw)
>         return FWTS_OK;
>  }
>
> -#if FWTS_TEST_VGA_REGION
> -static int mtrr_test4(fwts_framework *fw)
> -{
> -       return check_vga_controller_address(fw);
> -}
> -#endif
> -
>  static fwts_framework_minor_test mtrr_tests[] = {
>         { mtrr_test1, "Validate the kernel MTRR IOMEM setup." },
>         { mtrr_test2, "Validate the MTRR setup across all processors." },
>         { mtrr_test3, "Check for AMD MtrrFixDramModEn being cleared by the BIOS." },
> -#if FWTS_TEST_VGA_REGION
> -       { mtrr_test4, "Validate the BIOS providided boot time MTRR IOMEM setup." },
> -#endif
>         { NULL, NULL }
>  };
>
> --
> 1.8.0
>
Acked-by: Keng-Yu Lin <kengyu at canonical.com>



More information about the fwts-devel mailing list