fwts-collect addition

[Chris Van Hoof]

Hey guys -- I've been noticing we often ask for the output of 
intel_reg_dumper from the intel-gpu-tools package, typically a run 
before and after s3, or some form of corruption.

Since the bulk of machines we're working on already have fwts installed, 
I thought of adding intel_reg_dumper as a new function and running it if 
/sys/module/i915 exists in fwts-collect. Problem is, it requires sudo to 
run, which none of the existing tests in fwts-collect require.

Just curious if any of you have any thoughts here or if something like 
this would be better served by just using intel_reg_dumper directly 
opposed to integrating it into fwts-collect.

Here is a strace snippet filtering on files accessed when executing the 
command for reference:

"""
# strace -e trace=file -o strace.out intel_reg_dumper
execve("/usr/bin/intel_reg_dumper", ["intel_reg_dumper"], [/* 18 vars 
*/]) = 0
access("/etc/ld.so.nohwcap", F_OK)      = -1 ENOENT (No such file or 
directory)
access("/etc/ld.so.preload", R_OK)      = -1 ENOENT (No such file or 
directory)
open("/etc/ld.so.cache", O_RDONLY|O_CLOEXEC) = 3
access("/etc/ld.so.nohwcap", F_OK)      = -1 ENOENT (No such file or 
directory)
open("/usr/lib/x86_64-linux-gnu/libpciaccess.so.0", O_RDONLY|O_CLOEXEC) = 3
access("/etc/ld.so.nohwcap", F_OK)      = -1 ENOENT (No such file or 
directory)
open("/lib/x86_64-linux-gnu/libc.so.6", O_RDONLY|O_CLOEXEC) = 3
access("/etc/ld.so.nohwcap", F_OK)      = -1 ENOENT (No such file or 
directory)
open("/lib/x86_64-linux-gnu/libz.so.1", O_RDONLY|O_CLOEXEC) = 3
stat("/sys/bus/pci/devices", {st_mode=S_IFDIR|0755, st_size=0, ...}) = 0
open("/proc/mtrr", O_WRONLY)            = 3
openat(AT_FDCWD, "/sys/bus/pci/devices", 
O_RDONLY|O_NONBLOCK|O_DIRECTORY|O_CLOEXEC) = 4
open("/sys/bus/pci/devices/0000:00:00.0/config", O_RDONLY) = 4
open("/sys/bus/pci/devices/0000:00:02.0/config", O_RDONLY) = 4
open("/sys/bus/pci/devices/0000:00:16.0/config", O_RDONLY) = 4
open("/sys/bus/pci/devices/0000:00:19.0/config", O_RDONLY) = 4
open("/sys/bus/pci/devices/0000:00:1a.0/config", O_RDONLY) = 4
open("/sys/bus/pci/devices/0000:00:1b.0/config", O_RDONLY) = 4
open("/sys/bus/pci/devices/0000:00:1c.0/config", O_RDONLY) = 4
open("/sys/bus/pci/devices/0000:00:1c.1/config", O_RDONLY) = 4
open("/sys/bus/pci/devices/0000:00:1c.3/config", O_RDONLY) = 4
open("/sys/bus/pci/devices/0000:00:1c.4/config", O_RDONLY) = 4
open("/sys/bus/pci/devices/0000:00:1c.6/config", O_RDONLY) = 4
open("/sys/bus/pci/devices/0000:00:1d.0/config", O_RDONLY) = 4
open("/sys/bus/pci/devices/0000:00:1f.0/config", O_RDONLY) = 4
open("/sys/bus/pci/devices/0000:00:1f.2/config", O_RDONLY) = 4
open("/sys/bus/pci/devices/0000:00:1f.3/config", O_RDONLY) = 4
open("/sys/bus/pci/devices/0000:03:00.0/config", O_RDONLY) = 4
open("/sys/bus/pci/devices/0000:0d:00.0/config", O_RDONLY) = 4
open("/sys/bus/pci/devices/0000:0e:00.0/config", O_RDONLY) = 4
open("/sys/bus/pci/devices/0000:00:02.0/config", O_RDONLY) = 4
open("/sys/bus/pci/devices/0000:00:02.0/resource", O_RDONLY) = 4
open("/sys/bus/pci/devices/0000:00:02.0/resource0", O_RDWR) = 4
"""

--chris