[PATCH] uefi: Add fwts-efi-runtime-dkms package

[Chris Van Hoof]

On 08/22/2012 03:11 AM, Keng-Yu Lin wrote:
> On Wed, Aug 22, 2012 at 2:57 AM, Chris Van Hoof <vanhoof at canonical.com> wrote:
>> On 08/21/2012 11:58 AM, Colin Ian King wrote:
>>> On 21/08/12 06:12, Keng-Yu Lin wrote:
>>>> The patch adds the DKMS package for holding the FWTS UEFI runtime
>>>> service kernel driver.
>>>>
>>>> Signed-off-by: Keng-Yu Lin <kengyu at canonical.com>
>>>> ---
>>>>   debian/control                    |    9 ++++++++-
>>>>   debian/fwts-efi-runtime-dkms.dkms |    6 ++++++
>>>>   debian/rules                      |   17 ++++++++++++++++-
>>>>   3 files changed, 30 insertions(+), 2 deletions(-)
>>>>   create mode 100644 debian/fwts-efi-runtime-dkms.dkms
>>>>   create mode 100644 efi_runtime/Makefile
>>>>
>>>> Please put the driver in efi_runtime/.
>>>>
>>>> diff --git a/debian/control b/debian/control
>>>> index 1f93c6a..78d06b0 100644
>>>> --- a/debian/control
>>>> +++ b/debian/control
>>>> @@ -4,7 +4,7 @@ Priority: optional
>>>>   Maintainer: Firmware Testing Team
>>>> <firmware-testing-team at lists.launchpad.net>
>>>>   Uploaders: Colin King <colin.king at ubuntu.com>, Keng-Yu Lin
>>>> <kengyu at ubuntu.com>, Alex Hung <alex.hung at canonical.com>, Chris Van
>>>> Hoof <vanhoof at canonical.com>, Ivan Hu <ivan.hu at canonical.com>
>>>>   Standards-Version: 3.9.3
>>>> -Build-Depends: debhelper (>= 7.0.50~), autoconf, automake, libtool,
>>>> libpcre3-dev (>= 7.8), libjson0-dev (>= 0.9), flex, bison,
>>>> hardening-wrapper
>>>> +Build-Depends: debhelper (>= 7.0.50~), autoconf, automake, libtool,
>>>> libpcre3-dev (>= 7.8), libjson0-dev (>= 0.9), flex, bison,
>>>> hardening-wrapper, dkms
>>>>
>>>>   Package: fwts
>>>>   Architecture: any
>>>> @@ -52,3 +52,10 @@ Description: Firmware Test Suite frontend interface
>>>>    This is a dialog based interface designed to provide an easy to use
>>>> method
>>>>    to execute tests via Firmware Test Suite and is also used as the
>>>> primary
>>>>    interface within Firmware Test Suit live images.
>>>> +
>>>> +Package: fwts-efi-runtime-dkms
>>>> +Architecture: amd64
>>>
>>> Is the amd64 architecture required? Will "any" do instead?
>>
>> We're only dealing with UEFI on amd64, right? That's my guess.
>>
> 
> Yes, the package is only useful for a UEFI machine.
> 
> 
>>>> +Priority: optional
>>>> +Depends: ${shlibs:Depends}, ${misc:Depends}, dkms,
>>>> linux-headers-generic | linux-headers
>>>> +Description: Firmware Test Suite UEFI Runtime Service kernel driver
>>>> + This is a kernel driver for accessing the UEFI Runtime Services.
>>>
>>> Small niggle, but I suspect more than one line of description is
>>> probably required.
>>>
> 
> Let me try to have this fixed. (English is more difficult than coding
> for me :-/).

How about this?

"This package provides the efi_runtime kernel driver in DKMS format,
which is required for accessing UEFI Runtime Services."