[Bug 2083651] Re: debhelper 13.18ubuntu2 ignores arch-specific overrides causing lintian 2.118.0ubuntu1 to FTBFS

Sat Oct 19 02:09:08 UTC 2024

The Lintian side of this bug is in bug 2084708.

** Description changed:

  [ Impact ]
+ 
+ * This blocks the SRU tracked in bug 2084708.

  * A change in debhelper caused a regression in packages which used arch-
  specific debhelper configs.

  * This regression in particular causes lintian to FTBFS due to failing
  build-time tests which rely on specifying arch-specific lintian
  overrides ( e.g. package_name.lintian-overrides.amd64). This SRU will
  ensure lintian can build in Oracular and will not block other SRUs of
  packages which rely on these types of overrides.

  * The upload fixes the regression by cherry-picking changes from
  upstream Debian  to handle architecture specific overrides[0].

  [0]
  https://salsa.debian.org/debian/debhelper/-/commit/214c2a299dfcc1f0cb79ea4a0e80d67df54be19a

  [ Test Plan ]

  * Rebuild Lintian with the new version of debhelper, ensure it builds,
  and autopkgtests pass.

  * Ensure debhelpers autopkgtests and rev-dep's autopkgtests pass

  [ Where problems could occur ]

  * The upload overall feels low risk. The low hanging fruit here is that
  the patch is applied incorrectly (typo, incomplete, etc) and would cause
  the issue to not be fixed or even to cause debhelper to FTBFS now. I've
  demonstrated this isn't the case with passing PPA builds of both
  debhelper and lintian.

  * The more interesting scenario would be the potential for other
  packages which rely on the faulty behavior and will now appear to
  regress with the inclusion of the correct overrides. Although this would
  have to be something pretty contrived - like the lintian build tests
  which check for the existence of the overrides - since lintian overrides
  (AFAIU) typically suppress warning/errors instead of generating them.

- 
  [ Original Description ]

  lintian 2.118.0ubuntu1 had previously built[0], but now fails to build
  from source [1]. Version  2.118.2ubuntu1 stuck in oracular-proposed
  currently fails to build for the same reason.

  The particular failure is a build time test failure:

  # Hints do not match
  #
  # --- debian/test-out/eval/checks/debian/lintian-overrides/mystery/fields-multi-arch-same-package-has-arch-specific-overrides/hints.specified.calibrated
  # +++ debian/test-out/eval/checks/debian/lintian-overrides/mystery/fields-multi-arch-same-package-has-arch-specific-overrides/hints.actual.parsed
  # -fields-multi-arch-same-package-has-arch-specific-overrides-nonrel (binary): alien-tag foo [usr/share/lintian/overrides/fields-multi-arch-same-package-has-arch-specific-overrides-nonrel:1]
  # -fields-multi-arch-same-package-has-arch-specific-overrides (binary): alien-tag foo [usr/share/lintian/overrides/fields-multi-arch-same-package-has-arch-specific-overrides:1]
  # +
  #
  # Missing tags:
  #   alien-tag
  #
  #   Failed test 'Lintian passes for fields-multi-arch-same-package-has-arch-specific-overrides'
  #   at /<<PKGBUILDDIR>>/lib/Test/Lintian/Run.pm line 343.
  # Looks like you failed 1 test of 1.
  debian/test-out/eval/checks/debian/lintian-overrides/mystery/fields-multi-arch-same-package-has-arch-specific-overrides/generic.t .....
  Dubious, test returned 1 (wstat 256, 0x100)
  Failed 1/1 subtests

  [0] https://launchpad.net/ubuntu/+source/lintian/2.118.0ubuntu1/+build/28700466
  [1] https://launchpadlibrarian.net/749250106/buildlog_ubuntu-oracular-amd64.lintian_2.118.0ubuntu1_BUILDING.txt.gz
  [2] https://launchpad.net/ubuntu/+source/lintian/2.118.2ubuntu1/+build/29094257

** No longer affects: lintian (Ubuntu)

** No longer affects: lintian (Ubuntu Oracular)

** No longer affects: lintian (Ubuntu Plucky)

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to debhelper in Ubuntu.
https://bugs.launchpad.net/bugs/2083651

Title:
  debhelper 13.18ubuntu2 ignores arch-specific overrides causing lintian
  2.118.0ubuntu1 to FTBFS

Status in debhelper package in Ubuntu:
  In Progress
Status in debhelper source package in Oracular:
  In Progress
Status in debhelper source package in Plucky:
  In Progress

Bug description:
  [ Impact ]

  * This blocks the SRU tracked in bug 2084708.

  * A change in debhelper caused a regression in packages which used
  arch-specific debhelper configs.

  * This regression in particular causes lintian to FTBFS due to failing
  build-time tests which rely on specifying arch-specific lintian
  overrides ( e.g. package_name.lintian-overrides.amd64). This SRU will
  ensure lintian can build in Oracular and will not block other SRUs of
  packages which rely on these types of overrides.

  * The upload fixes the regression by cherry-picking changes from
  upstream Debian  to handle architecture specific overrides[0].

  [0]
  https://salsa.debian.org/debian/debhelper/-/commit/214c2a299dfcc1f0cb79ea4a0e80d67df54be19a

  [ Test Plan ]

  * Rebuild Lintian with the new version of debhelper, ensure it builds,
  and autopkgtests pass.

  * Ensure debhelpers autopkgtests and rev-dep's autopkgtests pass

  [ Where problems could occur ]

  * The upload overall feels low risk. The low hanging fruit here is
  that the patch is applied incorrectly (typo, incomplete, etc) and
  would cause the issue to not be fixed or even to cause debhelper to
  FTBFS now. I've demonstrated this isn't the case with passing PPA
  builds of both debhelper and lintian.

  * The more interesting scenario would be the potential for other
  packages which rely on the faulty behavior and will now appear to
  regress with the inclusion of the correct overrides. Although this
  would have to be something pretty contrived - like the lintian build
  tests which check for the existence of the overrides - since lintian
  overrides (AFAIU) typically suppress warning/errors instead of
  generating them.

  [ Original Description ]

  lintian 2.118.0ubuntu1 had previously built[0], but now fails to build
  from source [1]. Version  2.118.2ubuntu1 stuck in oracular-proposed
  currently fails to build for the same reason.

  The particular failure is a build time test failure:

  # Hints do not match
  #
  # --- debian/test-out/eval/checks/debian/lintian-overrides/mystery/fields-multi-arch-same-package-has-arch-specific-overrides/hints.specified.calibrated
  # +++ debian/test-out/eval/checks/debian/lintian-overrides/mystery/fields-multi-arch-same-package-has-arch-specific-overrides/hints.actual.parsed
  # -fields-multi-arch-same-package-has-arch-specific-overrides-nonrel (binary): alien-tag foo [usr/share/lintian/overrides/fields-multi-arch-same-package-has-arch-specific-overrides-nonrel:1]
  # -fields-multi-arch-same-package-has-arch-specific-overrides (binary): alien-tag foo [usr/share/lintian/overrides/fields-multi-arch-same-package-has-arch-specific-overrides:1]
  # +
  #
  # Missing tags:
  #   alien-tag
  #
  #   Failed test 'Lintian passes for fields-multi-arch-same-package-has-arch-specific-overrides'
  #   at /<<PKGBUILDDIR>>/lib/Test/Lintian/Run.pm line 343.
  # Looks like you failed 1 test of 1.
  debian/test-out/eval/checks/debian/lintian-overrides/mystery/fields-multi-arch-same-package-has-arch-specific-overrides/generic.t .....
  Dubious, test returned 1 (wstat 256, 0x100)
  Failed 1/1 subtests

  [0] https://launchpad.net/ubuntu/+source/lintian/2.118.0ubuntu1/+build/28700466
  [1] https://launchpadlibrarian.net/749250106/buildlog_ubuntu-oracular-amd64.lintian_2.118.0ubuntu1_BUILDING.txt.gz
  [2] https://launchpad.net/ubuntu/+source/lintian/2.118.2ubuntu1/+build/29094257

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/debhelper/+bug/2083651/+subscriptions