[Bug 2061825] Re: [SRU] ucf fails to work for local diversions on Jammy

[Robie Basak]

Thank you for your reply. Unfortunately this doesn't address my concerns
though. Please address paragraphs 2, 3 and 4 from my comment 7 above.
Depending on your answer, it may be the case that I end up rejecting the
SRU because the impact is not sufficient to justify one (see:
https://wiki.ubuntu.com/StableReleaseUpdates#High-impact_bugs).

Thank you for working on the Test Plan, however please expand on "B3.
Confirm it still works". It's important that the steps you follow are
unambiguous in case we need to follow what happened after a regression.
Are you going to merely confirm that dpkg completes without errors,
check that the configuration file remains modified, verify that chrony
is returning NTP queries, or what? Please make sure that the cases I
outlined in paragraph 6 of comment 7 are umanbiguously and fully
covered.

The changelog update in your debdiff is much better, thanks, but it
needs re-uploading. I'll reject the existing upload.

Please get all the updates I've requested above completed to the
satisfaction of your sponsor, and then ask your sponsor to re-upload.
Thanks!

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ucf in Ubuntu.
https://bugs.launchpad.net/bugs/2061825

Title:
  [SRU] ucf fails to work for local diversions on Jammy

Status in ucf package in Ubuntu:
  Fix Released
Status in ucf source package in Jammy:
  In Progress

Bug description:
  [ Impact ]

  When a dpkg-diversion is used to setup a package diversion and ucf for managing
  the configuration files for chrony package, the postinst script of ucf fails
  when installing chrony.

  This issue isn't specific to chrony but can happen for any package whose
  config files are managed by ucf.

  This affects users on Jammy who use ucf. Newer versions of ucf have this bug
  fixed already.

  "ucf should respect dpkg-divert" (refer https://bugs.debian.org/cgi-
  bin/bugreport.cgi?bug=477773) indicates it is a feature and has been
  supported since 3.0040 and has been accepted by the upstream
  maintainer.

  
  [ Test Plan ]

  Common case.
  A1. Create a Jammy container or VM
  A2. Install chrony: apt install chrony -y
  A3. Confirm ucf works with no failures (including syntax errors)
  B1. Modify the configuration: /etc/chrony/chrony.conf
  B2. Remove chrony package and re-install
  B3. Confirm it still works.

  B. Case when a diversion is in place.
  1. Create a Jammy container or VM
  2. Setup a diversion for chrony.conf: dpkg-divert --package chrony --add --rename --divert /etc/chrony/chrony.conf.custom /etc/chrony/chrony.conf
  3. Install chrony: apt install chrony -y
  4. Notice the postinst script fail with syntax errors such as:
  ```
  Preparing to unpack .../chrony_4.2-2ubuntu2_amd64.deb ...
  Unpacking chrony (4.2-2ubuntu2) ...
  Setting up chrony (4.2-2ubuntu2) ...
  /usr/bin/ucf: 444: [: missing ]
  grep: ]: No such file or directory
  /usr/bin/ucf: 444: [: missing ]
  grep: ]: No such file or directory
  ```
  5. Install the package with the fix from the PPA: https://launchpad.net/~pponnuvel/+archive/ubuntu/ucf-jammy (to be replaced with the package from the -proposed pocket)
  6. Repeat the same from steps 1 to 4 and notice no failures at step4.

  [ Where problems could occur ]

  Can further introduce similar bugs if the patch contains similar syntax
  errors. Consequently local diversion may not take effect for packages
  using ucf to manage configuration files.

  [ Other Info ]

  Upstream bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=979354

  It's been fixed in version ucf/3.0043+nmu1. Lunar/Mantic/Noble all have the
  ucf version with this patch.

  Affects Jammy only and thus backported to only Jammy.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ucf/+bug/2061825/+subscriptions