[Bug 1990450] Re: Show potential Ubuntu Pro updates and apt news messages

[Sebastien Bacher]

Hey Andreas, thanks for the review

> The changes file for bionic-unapproved includes versions 18.04.11.16 up to 18.04.11.22, while the changes file for what was accepted into bionic-proposed is from 18.04.11.14 to 18.04.11.21.
>
> You can see the range of versions does not match each other, not even in a continuation scheme. Should bionic-unapproved be rejected?

the set selected here was to reflect the actual change of the SRU (the
previous revision was a testfix which doesn't need to be verified again
so was slightly confusing) but .15 should probably have been included,
though in practice it cover the same content and bug reference than the
entries included.

I personally wouldn't reject the upload over that but you are the SRU
reviewer so up to you at the end, let us know what you want to see
happening for the upload to be unblocked


> xenial-proposed has a changes file for just version 16.04.18, and xenial-unapproved's changes file is from 16.04.18 to 16.04.19.
> 
> in that form, xenial-unapproved would be ok to consider for sru review and acceptance on top of what is in xenial-proposed currently.

I'm unsure to understand what you describe there, from the queue
https://launchpadlibrarian.net/702021083/update-manager_16.04.19_source.changes

so the change includes the entries from .18 and .19 which are the
versions not yet in -updates. My understanding is that it matches the
common practice of including the changelog entry from the previous
upload when doing a follow-up fix for a version that didn't get verified
yet? If so I would say the xenial upload is as intended and should be
accepted

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1990450

Title:
  Show potential Ubuntu Pro updates and apt news messages

Status in update-manager package in Ubuntu:
  Fix Released
Status in update-manager source package in Xenial:
  Fix Committed
Status in update-manager source package in Bionic:
  Fix Committed
Status in update-manager source package in Focal:
  Fix Released
Status in update-manager source package in Jammy:
  Fix Released
Status in update-manager source package in Kinetic:
  Fix Released
Status in update-manager source package in Lunar:
  Won't Fix
Status in update-manager source package in Mantic:
  Won't Fix
Status in update-manager source package in Noble:
  Fix Released

Bug description:
  [Impact]
  Show the Ubuntu Pro (aka Ubuntu Advantage) updates that would be enabled if you attached this machine. This information is not currently shown.

  The new revision also update the reference to the Software Properties'
  Livepatch tab which doesn't exist anymore since bug #2003527 and was
  replaced by Ubuntu Pro.

  There is also a new section 'News' showing the apt-news messages if
  there are any available and some layout changes to accommodate for the
  new section

  [Test Case]
  1. Do fresh install of Ubuntu with available updates
  2. Check there are updates available by running:
  $ pro security-status
  Note that updates are only available for older LTS releases.
  If there are no Pro specific updates available, install any package listed in https://esm.ubuntu.com/apps/ubuntu/dists/jammy-apps-security/main/binary-amd64/Packages (without attaching your machine!)
  3. Open update-manager

  -> There should be a 'Ubuntu Pro security updates (Enable in
  Settings...)' section at the bottom of the updates list showing
  disabled and including under it the name of the packages that would be
  available if pro was enabled

  4. start software-properties, go to the ubuntu pro tab and attach to a pro account
  5. close software-properties and restart update-manager

  -> There should be a 'Ubuntu Pro security updates' section at the
  bottom of the updates list showing enabled and including under it
  packages updated provided by pro that can be installed

  6. Check the top of the update-manager dialog

  If there is a message available on the server
  $ curl https://motd.ubuntu.com/aptnews.json
  with a timestamp older than one month

  then a 'news' section should be displayed including the message

  if there isn't a recent post on the server it can be tested locally
  with the steps from #31

  [Regression Potential]
  Possibility of introducing new bugs.

  The new livepatch->ubuntu pro string change will not be translated
  until the next language pack refresh

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/1990450/+subscriptions