[Bug 2058035] Re: [SRU] Create directories for apt configuration files if they are absent

[Nathan Teodosio]

Autopkgtest for .13 succeeds:
https://autopkgtest.ubuntu.com/results/autopkgtest-
xenial/xenial/amd64/s/software-properties/20240403_080714_2ae06@/log.gz

** Tags removed: verification-needed verification-needed-xenial
** Tags added: verification-done verification-done-xenial

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to software-properties in Ubuntu.
https://bugs.launchpad.net/bugs/2058035

Title:
  [SRU] Create directories for apt configuration files if they are
  absent

Status in software-properties package in Ubuntu:
  Fix Released
Status in software-properties source package in Xenial:
  Fix Committed

Bug description:
  Impact
  ------

  The autopkgtest for 0.96.20.12, which introduces Ubuntu Pro in
  Xenial's software-properties, failed on Dbus tests[1].

  The failure is because, at some point in time, the .keep file were
  removed from the otherwise empty tests/aptroot/etc/apt/apt.conf.d/.
  This caused the Git repository to drop
  tests/aptroot/etc/apt/apt.conf.d/ and also its parent, which also
  became empty, and the tests try to directly create files in those
  directories, raising the error.

  It seems that previous uploaders did not use the Git checkout, as the
  offending commit was introduced in Jun 2019 and there were subsequent
  uploads that did contain those empty directories.

  Test case
  ---------

  Trigger an autopkgtest against the proposed package version. It must
  succeed.

  Regression Potential
  --------------------

  Although the introduced change is idempotent, there could be other
  part of the code assuming the directories didn't exist and trying to
  create them with a "fail if already exists" approach, causing a
  runtime regression.

  [1]
  https://objectstorage.prodstack5.canonical.com/swift/v1/AUTH_0f9aae918d5b4744bf7b827671c86842/autopkgtest-
  xenial/xenial/amd64/s/software-
  properties/20240301_100314_9e242@/log.gz

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/2058035/+subscriptions