[Bug 2036198] Re: minimize-manual script takes an argument but is not used throughout script

[Philip Roche]

MP https://code.launchpad.net/~philroche/livecd-rootfs/+git/livecd-
rootfs/+merge/451438 resolves this bug

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to livecd-rootfs in Ubuntu.
https://bugs.launchpad.net/bugs/2036198

Title:
  minimize-manual script takes an argument but is not used throughout
  script

Status in livecd-rootfs package in Ubuntu:
  New

Bug description:
  minimize-manual takes an argument of the path to the chroot but of the
  3 commands that are run the argument is only used twice and with the
  third hardcoding "chroot" as the path to the chroot.

  Thankfully "chroot" has been the patch passed in for the current uses
  of minimize-manual but this could cause issues later if that were to
  change.

  ```
  chroot=$1

  auto_packages=$(/usr/share/livecd-rootfs/auto-markable-pkgs $chroot)
  if [ -n "$auto_packages" ]; then
  	chroot chroot apt-mark auto $auto_packages
  fi
  [ -z "$(/usr/share/livecd-rootfs/auto-markable-pkgs $chroot 2> /dev/null)" ]

  ```

  See https://git.launchpad.net/livecd-rootfs/tree/minimize-manual

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/livecd-rootfs/+bug/2036198/+subscriptions