[Bug 2039172] Re: grub 2.12~rc1 fails to load files from large directories on XFS
Steve Langasek
2039172 at bugs.launchpad.net
Tue Nov 28 04:42:03 UTC 2023
Hello Julian, or anyone else affected,
Accepted grub2 into mantic-proposed. The package will build now and be
available at
https://launchpad.net/ubuntu/+source/grub2/2.12~rc1-10ubuntu4.1 in a few
hours, and then in the -proposed repository.
Please help us by testing this new package. See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed. Your feedback will aid us getting this
update out to other Ubuntu users.
If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
mantic to verification-done-mantic. If it does not fix the bug for you,
please add a comment stating that, and change the tag to verification-
failed-mantic. In either case, without details of your testing we will
not be able to proceed.
Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in
advance for helping!
N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.
** Changed in: grub2 (Ubuntu Mantic)
Status: Incomplete => Fix Committed
--
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to grub2 in Ubuntu.
https://bugs.launchpad.net/bugs/2039172
Title:
grub 2.12~rc1 fails to load files from large directories on XFS
Status in grub2 package in Ubuntu:
Fix Released
Status in grub2-unsigned package in Ubuntu:
Fix Released
Status in ubuntu-release-upgrader package in Ubuntu:
Fix Released
Status in grub2 source package in Mantic:
Fix Committed
Status in grub2-unsigned source package in Mantic:
Fix Committed
Status in ubuntu-release-upgrader source package in Mantic:
Fix Released
Status in grub2 source package in Noble:
Fix Released
Status in grub2-unsigned source package in Noble:
Fix Released
Status in ubuntu-release-upgrader source package in Noble:
Fix Released
Status in grub2 package in Debian:
Fix Released
Bug description:
[Impact]
Multi-extent directories are not parsed correctly by grub's XFS code in 2.12~rc1, preventing it from loading files from directories with too many entries, such as the grub module directory.
This should only affect BIOS systems as they need to load the core
grub modules from the module directory, whereas UEFI systems have them
embedded in the ESP EFI image.
[Test plan: ubuntu-release-upgrader]
On systems BIOS systems with XFS /boot, or XFS / and no separate boot partition, the upgrade should be prevented early on with a message linking to this bug report.
We should also test upgrades on "normal"/unaffected system to make
sure it is not unnecessarily prevented.
[Where problems could occur: ubuntu-release-upgrader]
The two risks here are (1) missing a case where we should block upgrade, and (2) preventing an upgrade in a case where we should not. The unit tests included in the patch attempt to mitigate this risk.
Any issues would probably come from logic errors in the code that
parses /proc/mounts.
[Test plan: grub2, grub2-unsigned]
We'll do both grub2 on BIOS and UEFI.
- Install system with separate /boot on ext4.
- Upgrade to new grub. Run grub-install to actually apply bios-upgrade
- Reboot (this ensures ext4 still works)
- Take a backup of /boot
- Format /boot as xfs and restore backup
- Reboot (this ensures xfs works)
[Where problems could occur: grub2, grub2-unsigned]
We could be introducing other XFS parsing bugs including security vulnerabilities.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/2039172/+subscriptions
More information about the foundations-bugs
mailing list