[Bug 1896638] Please test proposed package

[Steve Langasek]

Hello Francis, or anyone else affected,

Accepted hibagent into focal-proposed. The package will build now and be
available at
https://launchpad.net/ubuntu/+source/hibagent/1.0.1-0ubuntu1.20.04.1 in
a few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
focal to verification-done-focal. If it does not fix the bug for you,
please add a comment stating that, and change the tag to verification-
failed-focal. In either case, without details of your testing we will
not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: hibagent (Ubuntu Bionic)
       Status: In Progress => Fix Committed

** Tags removed: verification-done-bionic
** Tags added: verification-needed-bionic

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to hibagent in Ubuntu.
https://bugs.launchpad.net/bugs/1896638

Title:
  Path to swapfile doesn't use a static device path

Status in ec2-hibinit-agent package in Ubuntu:
  Fix Released
Status in hibagent package in Ubuntu:
  Fix Released
Status in ec2-hibinit-agent source package in Xenial:
  Fix Released
Status in hibagent source package in Xenial:
  New
Status in ec2-hibinit-agent source package in Bionic:
  Fix Released
Status in hibagent source package in Bionic:
  Fix Committed
Status in ec2-hibinit-agent source package in Focal:
  Fix Released
Status in hibagent source package in Focal:
  Fix Committed
Status in ec2-hibinit-agent source package in Groovy:
  Fix Released
Status in hibagent source package in Groovy:
  Won't Fix
Status in hibagent source package in Jammy:
  Fix Committed
Status in hibagent source package in Kinetic:
  Fix Committed

Bug description:
  [Impact]

  * Using the device name on the kernel cmdline in the resume= option
  leads to failure to resume from hibernation when the device name is
  not stable, which can be the case for nvme drives.

  [Test Case]

  * ec2-hibinit-agent

    * Set up an EC2 instance to allow hibernation
    * Wait for hibinit-agent.service fully started
    * /etc/default/grub.d/99-set-swap.cfg should refer to the resume=partition by PARTUUID

  * hibagent

    * Spin up an EC2 spot instance with `hibernate` as `Interruption behavior` [1].
    * Install the latest hibagent: `sudo apt-get install hibagent`
    * Enable hibernation: `sudo /usr/bin/enable-ec2-spot-hibernation`
    * Create an AWS FIS experiment template to send a spot-instance-interruption signal [2], make it point to the created instance and launch it.
      Note: This step is optional, one can wait for AWS EC2 to send the interruption signal, but it could take a lot of time.
    * After some minutes, EC2 will send a signal to resume the interrupted instance.
    * Verify the instance has correctly been resumed from hibernation.

  [1] https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/interruption-behavior.html#specifying-spot-interruption-behavior
  [2] https://catalog.us-east-1.prod.workshops.aws/workshops/5fc0039f-9f15-47f8-aff0-09dc7b1779ee/en-US/030-basic-content/078-ec2-spot/020-spot-ec2-interrup

  [Regression Potential]

  * Failure to discover PARTUUID makes the system unable to resume. A
  potential crash would cause the system unable to set up hibernation or
  unable to resume. (On Focal PARTUUID is already in use, even without
  this fix.)

  [Original Bug Text]

  When the agent inserts the resume device path and offset into the
  kernel cmdline, it uses device names such as the following:

  `resume_offset=223232 resume=/dev/nvme1n1p1`

  The issue is that `/dev/nvme1n1p1` is not static. On the reboot, the
  block device may appear at `/dev/nvme0n1p1` resulting in failure to
  find the swapfile used to suspend.

  The solution should be to use a persistent block device naming scheme.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ec2-hibinit-agent/+bug/1896638/+subscriptions