[Bug 1995100] Re: /usr/share/apport/whoopsie-upload-all:ValueError:/usr/share/apport/whoopsie-upload-all at 249:main:collect_info:process_report:load

[Benjamin Drung]

Verified for kinetic:

```
$ echo > malformed.crash
$ apport-unpack malformed.crash unpack
ERROR: Malformed problem report: Line '\n' does not contain a colon for separating the key from the value.
```

** Tags removed: verification-needed verification-needed-kinetic
** Tags added: verification-done verification-done-kinetic

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1995100

Title:
  /usr/share/apport/whoopsie-upload-
  all:ValueError:/usr/share/apport/whoopsie-upload-
  all at 249:main:collect_info:process_report:load

Status in Apport:
  Fix Released
Status in apport package in Ubuntu:
  Fix Released
Status in apport source package in Kinetic:
  Fix Committed

Bug description:
  Impact
  ======

  apport-unpack and whoopsie-upload-all can crash when fed with a
  malformed problem report. They should print a proper error message
  instead of crashing. This is the most occurring apport bug in Ubuntu
  22.10 (kinetic) with as of writing 14,822 reported crashes.

  Test Plan
  =========

  1. Create malformed report:
  ```
  echo > malformed.crash
  ```
  2. Try to unpack it:
  ```
  apport-unpack malformed.crash unpack
  ```

  It should print an error message instead of a stack trace.

  Where problems could occur
  ==========================

  The patch touches the problem report handling and therefore can affect
  apport-unpack, apport-bug, whoopsie-upload-all. The change is covered
  with tests and apport has a test suite running during build and as
  autopkgtest.

  Original report
  ===============

  ```
  Traceback (most recent call last):
    File "/usr/share/apport/whoopsie-upload-all", line 249, in <module>
      main()
    File "/usr/share/apport/whoopsie-upload-all", line 231, in main
      stamps = collect_info()
    File "/usr/share/apport/whoopsie-upload-all", line 162, in collect_info
      res = process_report(r)
    File "/usr/share/apport/whoopsie-upload-all", line 76, in process_report
      r.load(f, binary="compressed")
    File "/usr/lib/python3/dist-packages/problem_report.py", line 166, in load
      (key, value) = line.split(b":", 1)
  ValueError: not enough values to unpack (expected 2, got 1)
  ```

  The Ubuntu Error Tracker has been receiving reports about a problem regarding apport.  This problem was most recently seen with package version 2.23.1-0ubuntu3, the problem page at https://errors.ubuntu.com/problem/134ffbe13e7dd9a7f79ad6a455c6e560669a9928 contains more details, including versions of packages affected, stacktrace or traceback, and individual crash reports.
  If you do not have access to the Ubuntu Error Tracker and are a software developer, you can request it at http://forms.canonical.com/reports/.

To manage notifications about this bug go to:
https://bugs.launchpad.net/apport/+bug/1995100/+subscriptions