[Bug 2022927] Re: Busybox mount fails to mount Snaps

[Bryce Harrington]

Hi Isaac,

I'm at end of my shift so don't have time for a full review, just a few
notes before I hand-off to the next patch pilot:

  - In your changelog entry, please reference this bug report, i.e.:
    

  - I'd recommend making your PPA version be "1:1.35.0-4ubuntu2~ppa5"

  - Name your patch "mount-ignore-x-options" as "mount-ignore-x-
options.patch"

  - I'd strongly recommend including DEP3 headers on your patch.  See
https://dep-team.pages.debian.net/deps/dep3/.  If you refer to the
busybox patch static-sh-alias.patch you can see a good example of this.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to busybox in Ubuntu.
https://bugs.launchpad.net/bugs/2022927

Title:
  Busybox mount fails to mount Snaps

Status in busybox package in Ubuntu:
  New

Bug description:
  Snapd tries to mount squashfs Snaps with non-standard mount flags like
  "x-gdu.hide" and "x-gvfs-hide", both of which are used to indicate to
  userspace programs that a given mount should not be shown in a list of
  mounted partitions/filesystems. Busybox does not support these flags,
  and so fails with "Invalid argument".

  $ sudo busybox mount -t tmpfs -o x-gdu-hide test /tmp/test
  mount: mounting test on /tmp/test failed: Invalid argument

  These flags can likely be be safely ignored, as they don't actually
  affect the functionality of the mount. This goes for all mount options
  starting with "x-", as these generally denote non-standard mount
  option "extensions".

  I've created a patch against Busybox which adds an optional
  configuration item to ignore all mount options beginning with "x-". An
  additional verbose option has also been added to enable the ability to
  report that the mount flags have been ignored, rather than silently
  ignoring them.

  This is a requirement for a customer project, where we are limited to
  using Busybox (due to coreutils' GPL-3.0 licence) but would also
  require using Snaps like checkbox for testing and verification. This
  was posted on the Busybox mailing list a few months ago
  (http://lists.busybox.net/pipermail/busybox/2023-March/090202.html)
  but patch acceptance there seems to take quite a long time, and we
  need this for the customer.

  A PPA containing the patched Busybox version is available on the
  project's Launchpad team: https://launchpad.net/~nemos-
  team/+archive/ubuntu/ppa

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/busybox/+bug/2022927/+subscriptions