[Bug 2002168] Re: apt-check needs to consider the pro client's esm cache for updates when esm is disabled

[Andreas Hasenack]

Hello Renan, or anyone else affected,

Accepted update-notifier into jammy-proposed. The package will build now
and be available at https://launchpad.net/ubuntu/+source/update-
notifier/3.192.54.5 in a few hours, and then in the -proposed
repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
jammy to verification-done-jammy. If it does not fix the bug for you,
please add a comment stating that, and change the tag to verification-
failed-jammy. In either case, without details of your testing we will
not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: update-notifier (Ubuntu Jammy)
       Status: New => Fix Committed

** Tags added: verification-needed verification-needed-jammy

** Changed in: update-notifier (Ubuntu Focal)
       Status: New => Fix Committed

** Tags added: verification-needed-focal

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to update-notifier in Ubuntu.
https://bugs.launchpad.net/bugs/2002168

Title:
  apt-check needs to consider the pro client's esm cache for updates
  when esm is disabled

Status in update-notifier package in Ubuntu:
  Fix Released
Status in update-notifier source package in Xenial:
  New
Status in update-notifier source package in Bionic:
  New
Status in update-notifier source package in Focal:
  Fix Committed
Status in update-notifier source package in Jammy:
  Fix Committed
Status in update-notifier source package in Lunar:
  Fix Released

Bug description:
  [ Impact ]

  Currently, the Pro Client sets up ESM sources in the system's APT
  configuration to advertise ESM updates even when the service is
  disabled. This is undesired, as described in

  https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-
  tools/+bug/1990378

  The next version of ubuntu-advantage-client will not bring this
  configuration anymore, and will remove it from systems where it
  exists.

  Update Notifier relies on those unauthenticated ESM sources. It needs
  instead to rely on the Pro Client ESM apt cache to provide this
  information.

  If this is not changes, users will not see any ESM update or
  advertisement if they don't have the services enabled.

  The change in the reporting strategy will land in ubuntu-advantage-
  tools and will be SRUed back to Xenial, Bionic, Focal and Jammy.

  [ Test Plan ]

  In a Ubuntu LTS system (Xenial for esm-infra, bionic/focal for esm-apps):
    - Verify that the ubuntu-advantage-tools version installed is greater than 27.12
    - Verify that no ESM updates are reported when running /usr/lib/update-notifier/apt-check --human-readable
    - Install a version of update-notifier with the change (from -proposed, or from the MR branch if not uploaded yet)
    - Verify that ESM updates are when running /usr/lib/update-notifier/apt-check --human-readable

  [ Where problems could occur ]

  In the event of the change being implemented in a wrong/incomplete
  way, the side-effect is that users would not see the ESM updates, same
  as not implementing the change. However, it is simple enough to verify
  if this happens, and it is highly improbable that it does.

  [ Other Info ]

  Instead of reading the esm apt cache from the Pro Client, update-
  notifier could query the 'packages' API provided in the Client itself.
  However, for that to happen, it would make sense for the package to
  depend (or at least recommend) ubuntu-advantage-tools.

  Even using the esm apt cache would be a fair reason for update-
  notifier to recommend ubuntu-advantage-tools - but it is the same kind
  of coupling (relying on implementation) as reading the "never" pin
  from esm repositories, so there is no hard requirement to add the soft
  dependency.

  There is no upload to Kinetic because there are no ESM packages there.
  There is no report of ESM data today, and there will be no report even
  if this lands there.

  For future changes, we want to redesign how this interaction between
  ubuntu-advantage-tools and update-notificer works, and then the
  definitive solution should land on all supported releases.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/2002168/+subscriptions