[Bug 2004208] Re: arm64 package has hardcoded x64 references

[dann frazier]

= kinetic verification =
shim-signed 1.54+15.7-0ubuntu1

In both an arm64 VM and an x86 VM, each with SecureBoot active, I did
the following:

With only a kernel installed that was signed by the old key, I installed
shim-signed from -proposed and verified that the shim alternative was
set to the "previous" version. I then installed a new kernel from
-proposed, signed by the new key, and verified that the shim alternative
remained set to the "previous" version. I think rebooted, and ran 'sudo
dpkg-reconfigure shim-signed', and verified that the alternative was now
set to the "latest" shim version. I then rebooted once more to make sure
I could boot through the new shim.

= jammy verification =
shim-signed 1.51.3+15.7-0ubuntu1

same steps as kinetic

= focal verification =
shim-signed: 1.40.9+15.7-0ubuntu1
same steps as kinetic

= bionic verification =
shim-signed 1.37~18.04.13+15.7-0ubuntu1

same steps as kinetic for amd64, which passed. However, I hit an issue
on arm64 - bug 2004437 - so I'm unable to complete verification for
that.

** Tags removed: verification-needed-focal verification-needed-jammy verification-needed-kinetic
** Tags added: verification-done-focal verification-done-jammy verification-done-kinetic

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to shim-signed in Ubuntu.
https://bugs.launchpad.net/bugs/2004208

Title:
  arm64 package has hardcoded x64 references

Status in canonical-signing-jobs:
  Fix Released
Status in canonical-signing-jobs task00 series:
  Fix Released
Status in canonical-signing-jobs task01 series:
  Fix Released
Status in canonical-signing-jobs task02 series:
  Fix Released
Status in canonical-signing-jobs task03 series:
  Fix Released
Status in shim-signed package in Ubuntu:
  New
Status in shim-signed source package in Bionic:
  Fix Committed
Status in shim-signed source package in Focal:
  Fix Committed
Status in shim-signed source package in Jammy:
  Fix Committed
Status in shim-signed source package in Kinetic:
  Fix Committed

Bug description:
  [Impact] 
  I couldn't figure out why the alternative wasn't being updated to the new shim after I installed a kernel installed w/ a 2022 key. Turns out its because we hardcode shim*x64* in the kernel hook:

  ubuntu at ubuntu:~$ grep x64 /etc/kernel/postinst.d/zz-shim
  if update-alternatives --query shimx64.efi.signed | grep "Best: /usr/lib/shim/shimx64.efi.signed.previous" -q; then

  There also seems to be a number of residual x64 references in the postinst:
  ubuntu at ubuntu:~$ grep x64 /var/lib/dpkg/info/shim-signed.*
  /var/lib/dpkg/info/shim-signed.postinst:	for efi_arch in x64 aa64; do
  /var/lib/dpkg/info/shim-signed.postinst:			update-alternatives --install /usr/lib/shim/shim${efi_arch}.efi.signed shimx64.efi.signed /usr/lib/shim/shim${efi_arch}.efi.signed.latest 100
  /var/lib/dpkg/info/shim-signed.postinst:			update-alternatives --install /usr/lib/shim/shim${efi_arch}.efi.signed shimx64.efi.signed /usr/lib/shim/shim${efi_arch}.efi.signed.previous 50
  /var/lib/dpkg/info/shim-signed.postinst:			update-alternatives --install /usr/lib/shim/shim${efi_arch}.efi.signed shimx64.efi.signed /usr/lib/shim/shim${efi_arch}.efi.signed.latest 50
  /var/lib/dpkg/info/shim-signed.postinst:			update-alternatives --install /usr/lib/shim/shim${efi_arch}.efi.signed shimx64.efi.signed /usr/lib/shim/shim${efi_arch}.efi.signed.previous 100
  /var/lib/dpkg/info/shim-signed.postinst:	if update-alternatives --query shimx64.efi.signed | grep "Best: /usr/lib/shim/shimx64.efi.signed.previous" -q; then

  [Test plan]
  Install a kernel signed with 2022 key on arm64, make sure that shimaa64.efi.signed alternative points to latest

  [Where problems could occur]
  Added/changed code could potentially break stuff on amd64.

To manage notifications about this bug go to:
https://bugs.launchpad.net/canonical-signing-jobs/+bug/2004208/+subscriptions