[Bug 2028180] Re: [SRU][Ubuntu 22.04] Duplicate link for NVMe device by-id

[Launchpad Bug Tracker]

** Merge proposal linked:
   https://code.launchpad.net/~enr0n/ubuntu/+source/systemd/+git/systemd/+merge/449220

** Merge proposal linked:
   https://code.launchpad.net/~enr0n/ubuntu/+source/systemd/+git/systemd/+merge/449221

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to systemd in Ubuntu.
https://bugs.launchpad.net/bugs/2028180

Title:
  [SRU][Ubuntu 22.04] Duplicate link for NVMe device by-id

Status in systemd package in Ubuntu:
  Fix Released
Status in systemd source package in Jammy:
  New
Status in systemd source package in Kinetic:
  Won't Fix
Status in systemd source package in Lunar:
  New
Status in systemd source package in Mantic:
  Fix Released

Bug description:
  [Impact]

  When working with NVMe/TCP host functionality, connecting to NVMe
  subsystem through multiple controllers can lead to an invalid device
  link created in /dev/disc/by-id/ being created.

  Steps to reproduce:
  Step 1: Install Ubuntu 22.04 LTS (ubuntu-22.04.1-live-server-amd64) on system.
  Step 2: Install nvme-cli package, currently installed version is nvme version 1.16
  Step 3: In the os terminal, type any nvme connect-all to connect to NVMe subsystems and check the duplicate entries in /dev/disk/by-id/.

  This may cause users to choose the wrong link and would not be able to
  work with it.

  [Fix]

  udev-rules: fix nvme symlink creation on namespace changes
  https://github.com/systemd/systemd/commit/c5ba7a2a4dd19a2d31b8a9d52d3c4bdde78387f0

  [Test Plan]
  Connect to NVMe/TCP subsystem using nvme connect-all. This was tested against a few Dell Storage systems.

  Steps to Reproduce:
  1. Use nvme connect-all to connect to an NVMe/TCP subsystems
  2. Check /dev/disk/by-id. The symlinks for NVMe devices should have the namespace id appended to them. E.g., if there is /dev/disk/by-id/nvme-$FOO, there should be a /dev/disk/by-id/name-$FOO_$ID.

  [ Where problems could occur ]
  This issue may be experienced by users who use NVMe/TCP solutions.
  Regression risk is low, because the existing symlink pattern is kept for backwards compatibility. This patch adds a new symlink pattern that includes the namespace ID, which will remain persistent throughout a boot.

  [ Other Info ]

  Expected Behavior:
  No duplicate entries of NVMe subsystems should exist.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/2028180/+subscriptions