[Bug 2025563] Re: System can not shutdown if system has multiple VROC RAID arrays
Nick Rosbrook
2025563 at bugs.launchpad.net
Fri Aug 4 14:35:10 UTC 2023
Hi Cyrus,
Do you have an example of a system actually failing to shut down due to
this? I don't see a problem with the patch per se, but I also am not
convinced that without it a system just would not shutdown...
That code is basically a safety net. If I understand the code correctly,
it should just ignore the failure of stopping some md devices, and
continue on anyways. Certainly there would be log messages about this,
but again, I don't see where this would prevent shutdown.
** Changed in: systemd (Ubuntu Jammy)
Status: New => Incomplete
** Changed in: systemd (Ubuntu)
Importance: Critical => Medium
** Changed in: systemd (Ubuntu Jammy)
Importance: Critical => Medium
--
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to systemd in Ubuntu.
https://bugs.launchpad.net/bugs/2025563
Title:
System can not shutdown if system has multiple VROC RAID arrays
Status in OEM Priority Project:
In Progress
Status in systemd package in Ubuntu:
Fix Released
Status in systemd source package in Jammy:
Incomplete
Status in systemd source package in Kinetic:
Fix Released
Bug description:
[ Impact ]
The system can not shutdown if the system has multiple VROC RAID arrays.
Intel has fixed it in systemd v251 [1].
Need to cherry-pick the commit to ubuntu-jammy systemd 249.11-0ubuntu3.9.
[1] The commit fixes the issue:
commit 3a3b022d2cc112803ea7b9beea98bbcad110368a
Author: Mariusz Tkaczyk <mariusz.tkaczyk at linux.intel.com>
Date: Tue Mar 29 12:49:54 2022 +0200
shutdown: get only active md arrays.
Current md_list_get() implementation filters all block devices, started from
"md*". This is ambiguous because list could contain:
- partitions created upon md device (mdXpY)
- external metadata container- specific type of md array.
For partitions there is no issue, because they aren't handle STOP_ARRAY
ioctl sent later. It generates misleading errors only.
Second case is more problematic because containers are not locked in kernel.
They are stopped even if container member array is active. For that reason
reboot or shutdown flow could be blocked because metadata manager cannot be
restarted after switch root on shutdown.
Add filters to remove partitions and containers from md_list. Partitions
can be excluded by DEVTYPE. Containers are determined by MD_LEVEL
property, we are excluding all with "container" value.
Signed-off-by: Mariusz Tkaczyk <mariusz.tkaczyk at linux.intel.com>
[ Test Plan ]
1. Build two VROC RAID. One RAID 0 for System volume, another RAID 10 for Data volume.
2. Install system on System volume.
3. Update systemd.
4. Reboot the system.
5. Verify if the system can reboot.
[ Where problems could occur ]
The patch confirmed fixed the reboot issue on the system with two VROC
RAIDs but more than two VROC RAIDs and the combinations of RAID levels
are not all tested.
[ Scope ]
Jammy
To manage notifications about this bug go to:
https://bugs.launchpad.net/oem-priority/+bug/2025563/+subscriptions
More information about the foundations-bugs
mailing list