[Bug 2015355] Re: Please backport patches for false atari partition detection to Ubuntu 20.04

[oldman]

I did a test dpkg-buildpackage after applying the patch and confirmed
the fix works as expected.

With libblkid1 2.34-0.1ubuntu9.3
$ blkid example.img
example.img: UUID="b4290c76-d481-4c8b-8407-8e7b6c3f11d5" TYPE="crypto_LUKS" PTTYPE="atari"
# wipefs example.img
DEVICE      OFFSET TYPE        UUID                                 LABEL
example.img 0x0    crypto_LUKS b4290c76-d481-4c8b-8407-8e7b6c3f11d5
example.img 0x4000 crypto_LUKS b4290c76-d481-4c8b-8407-8e7b6c3f11d5
example.img 0x1c6  atari

Imported patch and bumped dch to build 2.34-0.1ubuntu9.4

curl --fail -sSL -o debian/patches/2015355.patch "https://bugs.launchpad.net/ubuntu/+source/util-linux/+bug/2015355/+attachment/5661201/+files/2015355.patch"
quilt import debian/patches/2015355.patch
quilt push -a && quilt refresh && quilt pop -a
dch -n "Apply atari fix from #2015355."
dpkg-buildpackage -us -uc

Tested with libblkid1 2.34-0.1ubuntu9.4
# blkid  example.img
example.img: UUID="b4290c76-d481-4c8b-8407-8e7b6c3f11d5" TYPE="crypto_LUKS"
# wipefs example.img
DEVICE      OFFSET TYPE        UUID                                 LABEL
example.img 0x0    crypto_LUKS b4290c76-d481-4c8b-8407-8e7b6c3f11d5
example.img 0x4000 crypto_LUKS b4290c76-d481-4c8b-8407-8e7b6c3f11d5

(no more false positive PTTYPE="atari")

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to util-linux in Ubuntu.
https://bugs.launchpad.net/bugs/2015355

Title:
  Please backport patches for false atari partition detection to Ubuntu
  20.04

Status in util-linux package in Ubuntu:
  New

Bug description:
  There are three patches in util-linux upstream that were released in
  util-linux 2.37 and prevent false detection of the atari partition
  table with blkid and wipefs. We see this mostly on LUKS devices
  initialised via luksFormat reporting there is an atari partition table
  on the device when it is empty. This causes issues in various places,
  but one key example for us is in kubernetes where mount-utils will
  refuse to format the device (https://github.com/kubernetes/mount-
  utils/blob/732a08ae47571516020ef99c303c70c1fa5b3e6c/mount_linux.go#L437-L441)

  RedHat backported these fixes to RHEL 8 under
  https://bugzilla.redhat.com/show_bug.cgi?id=2060030 and it would be
  helpful if Ubuntu also backported them to Ubuntu 20.04 which is still
  running util-linux 2.34

  The request is to backport patches based on the
  https://github.com/util-linux/util-linux/issues/1159 upstream report.

  Upstream commits to cherry-pick the changes to libblkid/src/partitions/atari.c from: 
  2cc76d50d7a14bef8e7b07fab11b26c9e49d36a2
  282ceadc3a72fc07dd0388b8880fd751490bb87f
  c70b4f2a5b99876d230b8f4f413c3bb3ee6647f1

  # lsb_release -a
  Distributor ID: Ubuntu
  Description:    Ubuntu 20.04.6 LTS
  Release:        20.04
  Codename:       focal
  # blkid -V
  blkid from util-linux 2.34  (libblkid 2.34.0, 14-Jun-2019)
  # blkid -p -s TYPE -s PTTYPE -o export /dev/mapper/pvc-7b331195-cd5a-4ab6-8fdc-552af4b9139d_encrypted
  DEVNAME=dev/mapper/pvc-7b331195-cd5a-4ab6-8fdc-552af4b9139d_encrypted
  PTTYPE=atari
  # lsblk
  ...
  sdc                                                    crypto_LUKS                 a79d2982-74f2-44c7-bb29-460768ebfe64                
  `-3600a09803830474a735d4c63744c4a56                    crypto_LUKS                 a79d2982-74f2-44c7-bb29-460768ebfe64                
    `-pvc-7b331195-cd5a-4ab6-8fdc-552af4b9139d_encrypted

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/util-linux/+bug/2015355/+subscriptions