[Bug 1990379] Re: [UBUNTU 20.04] zlib: inflate() does not update strm.adler if DFLTCC is used

[Frank Heimes]

I've just noticed another bug that I want to fix with the same package update: LP#1982583
But LP#1982583 affects only jammy and kinetic, not focal.

This means for fixing this bug (LP#1990379) for jammy and kinetic, please use these debdiffs:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1982583/comments/2
and for fixing this bug (LP#1990379) for focal, please take the focal debdiff from the previous comment:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1990379/comments/7

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to zlib in Ubuntu.
https://bugs.launchpad.net/bugs/1990379

Title:
  [UBUNTU 20.04] zlib: inflate() does not update strm.adler if DFLTCC is
  used

Status in Ubuntu on IBM z Systems:
  In Progress
Status in zlib package in Ubuntu:
  In Progress
Status in zlib source package in Focal:
  In Progress
Status in zlib source package in Jammy:
  In Progress
Status in zlib source package in Kinetic:
  In Progress

Bug description:
  SRU Justification:
  ------------------

  [ Impact ]

   * The zlib function inflate() does not update strm.adler
     in case DFLTCC is used.

   * This issue was exposed by Java Certification Kit (JCK) running on z15
     hardware and newer and impacts all JDK versions (8,11,17, etc.)
     that use the system default settings.

   * The JCK failure impacts the ability to certify Java SDKs on this
     platform/Linux-distribution combination.

   * On top the incorrect alder32 result may cause functional issues with
     Java applications that depend on the result.

  [ Test Plan ]

   * An affected Ubuntu release (20.04, 22.04 and 22.10) installed
     on a z15/LinuxONE III or newer system is needed.

   * Then it's possible to test the updated package with the help
     of a small test program (in C) that makes use of the zlib1g library
     or run the Java Certification Kit.

   * Test will be done by IBM.

  [ Where problems could occur ]

   * The patch is a one-line change:
     https://launchpadlibrarian.net/626003193/410-lp1990379.patch
     and there are not many issues to expect.

   * There could be a potential problem with the adler field
     in the strm struct.
     For example in case the struct is not as assumed or contains
     and unexpected value, which would then ripple through
     the other fields, too.

   * Structural changes could be identified with a test build that was done
     for all affected Ubuntu releases and for all major architectures:
     https://launchpad.net/~fheimes/+archive/ubuntu/lp1990379

  [ Other Info ]
   
   * The patch itself is the same for all zlib version in
     20.04, 22.04 and 22.10 - no further adjustments were needed.
  __________

  == Comment: #0 - Ilya Leoshkevich <iii at de.ibm.com> - 2022-09-21 05:02:24 ==
  inflate() does not update strm.adler if DFLTCC is used.

  Found with a JDK test.

  zlib-ng PR: https://github.com/zlib-ng/zlib-ng/pull/1349

  Updated zlib PR: https://github.com/madler/zlib/pull/410

  zlib tag: https://github.com/iii-i/zlib/releases/tag/dfltcc-20220920

  zlib diff:
  https://github.com/madler/zlib/compare/e6aed68ff815be74855ec6a19d6ae35065a4adb4..171d0ff3c9ed40da0ac14085ab16b766b1162069#diff-325baa03829572a9f26b4bb8b3cada1ddc637854529d6a6cb111b8c3ca785620

  Ubuntu 20.04 and later need to be fixed.

  ---
  External link: https://warthogs.atlassian.net/browse/PEI-28

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1990379/+subscriptions