[Bug 1991030] Re: [SRU] Rename ua status call on apt_check script
Lucas Albuquerque Medeiros de Moura
1991030 at bugs.launchpad.net
Mon Oct 3 01:08:35 UTC 2022
** Description changed:
[Impact]
There is an update on how we will output ua commands on the messages delivered by update-notifier.
This will just instruct the user to use that new command instead
[Test Case]
To test this change, use the following script:
---------------------------------------------
- #!/bin/sh
+ #!/bin/bash
set -e
-
- GREEN="\e[32m"
- RED="\e[31m"
- BLUE="\e[36m"
- END_COLOR="\e[0m"
series=$1
token=$2
name=$series-dev
function cleanup {
- lxc delete test --force
+ lxc delete $name --force
}
function on_err {
- echo -e "${RED}Test Failed${END_COLOR}"
+ echo -e "Test Failed"
cleanup
exit 1
}
trap on_err ERR
- function print_and_run_cmd {
- echo -e "${BLUE}Running:${END_COLOR}" "$@"
- echo -e "${BLUE}Output:${END_COLOR}"
- lxc exec test -- sh -c "$@"
- echo
- }
-
- function explanatory_message {
- echo -e "${BLUE}$@${END_COLOR}"
- }
-
- explanatory_message "Starting $series container"
- lxc launch ubuntu-daily:$series test
+ lxc launch ubuntu-daily:$series $name
sleep 10
- explanatory_message "Update ubuntu-advantage-tools package"
- explanatory_message "We need that package to enable services that cause motd message changes"
- print_and_run_cmd "add-apt-repository ppa:ua-client/staging -y"
- print_and_run_cmd "sudo apt-get update > /dev/null"
- print_and_run_cmd "sudo apt-get install ubuntu-advantage-tools -y > /dev/null"
- print_and_run_cmd "ua version"
+ # Update update-notifier package
+ lxc exec $name -- sh -c "echo \"deb http://archive.ubuntu.com/ubuntu $series-proposed main\" | tee /etc/apt/sources.list.d/proposed.list"
+ lxc exec $name -- sudo apt-get update > /dev/null
+ lxc exec $name -- sudo apt-get install update-notifier-common -y > /dev/null
+ lxc exec $name -- apt-cache policy update-notifier-common
- explanatory_message "Update update-notifier package"
- print_and_run_cmd "sh -c 'echo \"deb http://archive.ubuntu.com/ubuntu $series-proposed main\" | tee /etc/apt/sources.list.d/proposed.list'"
- print_and_run_cmd "sudo apt-get update > /dev/null"
- print_and_run_cmd "sudo apt-get install update-notifier -y > /dev/null"
- print_and_run_cmd "apt-cache policy update-notifier"
+ # Running update-motd for machine without an ua subscription
+ echo -e "\n* Updated update-notifier message"
+ echo "###########################################"
+ lxc exec $name -- /usr/lib/update-notifier/apt-check --human-readable
+ echo -e "###########################################\n"
- explanatory_message "Running update-motd for machine without an ua subscription"
- print_and_run_cmd "/usr/lib/update-notifier/apt-check --human-readable"
+ # Attaching machine to a UA subscription
+ echo "Attaching to a UA subscription"
+ lxc exec $name -- ua attach $token > /dev/null
+ lxc exec $name -- ua status
- explanatory_message "Attaching machine to a UA subscription"
- print_and_run_cmd "ua attach $token"
+ # Running update-motd for attached machine
+ echo -e "\n* Updated update-notifier message with system attached to UA"
+ echo -e "###########################################"
+ lxc exec $name -- /usr/lib/update-notifier/apt-check --human-readable
+ echo -e "###########################################\n"
- explanatory_message "Running update-motd for attached machine"
- print_and_run_cmd "/usr/lib/update-notifier/apt-check --human-readable"
+ # Installing all esm-infra packages
+ lxc exec $name -- sudo apt-get upgrade -y > /dev/null
- explanatory_message "Installing all esm-infra packages"
- print_and_run_cmd "sudo apt-get upgrade -y > /dev/null"
+ # Disabling esm-infra
+ lxc exec $name -- sudo pro disable esm-infra > /dev/null
- explanatory_message "Disabling esm-infra"
- print_and_run_cmd "sudo pro disable esm-infra"
-
- explanatory_message "Running update-motd for attached machine"
- print_and_run_cmd "/usr/lib/update-notifier/apt-check --human-readable"
+ echo "* Updated update-notifier message with esm-infra disabled"
+ echo "###########################################"
+ lxc exec $name -- /usr/lib/update-notifier/apt-check --human-readable
+ echo -e "###########################################\n"
cleanup
-----------------------------------------------------
Notice that you need a UA token to run this script.
Additionally, most messages will appear on the xenial machine due to it being ESM already
[Regression Potential]
We are just providing message changes, so the regression potential is really low. User might notice the changes, but they are not that different from the original ones.
Like in bug 1980368, translatable strings are affected, but we accept
them for the same reason as we did in that bug.
--
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to update-notifier in Ubuntu.
https://bugs.launchpad.net/bugs/1991030
Title:
[SRU] Rename ua status call on apt_check script
Status in update-notifier package in Ubuntu:
Fix Released
Status in update-notifier source package in Xenial:
Fix Committed
Status in update-notifier source package in Bionic:
Fix Committed
Status in update-notifier source package in Focal:
Fix Committed
Status in update-notifier source package in Jammy:
Fix Committed
Status in update-notifier source package in Kinetic:
Fix Released
Bug description:
[Impact]
There is an update on how we will output ua commands on the messages delivered by update-notifier.
This will just instruct the user to use that new command instead
[Test Case]
To test this change, use the following script:
---------------------------------------------
#!/bin/bash
set -e
series=$1
token=$2
name=$series-dev
function cleanup {
lxc delete $name --force
}
function on_err {
echo -e "Test Failed"
cleanup
exit 1
}
trap on_err ERR
lxc launch ubuntu-daily:$series $name
sleep 10
# Update update-notifier package
lxc exec $name -- sh -c "echo \"deb http://archive.ubuntu.com/ubuntu $series-proposed main\" | tee /etc/apt/sources.list.d/proposed.list"
lxc exec $name -- sudo apt-get update > /dev/null
lxc exec $name -- sudo apt-get install update-notifier-common -y > /dev/null
lxc exec $name -- apt-cache policy update-notifier-common
# Running update-motd for machine without an ua subscription
echo -e "\n* Updated update-notifier message"
echo "###########################################"
lxc exec $name -- /usr/lib/update-notifier/apt-check --human-readable
echo -e "###########################################\n"
# Attaching machine to a UA subscription
echo "Attaching to a UA subscription"
lxc exec $name -- ua attach $token > /dev/null
lxc exec $name -- ua status
# Running update-motd for attached machine
echo -e "\n* Updated update-notifier message with system attached to UA"
echo -e "###########################################"
lxc exec $name -- /usr/lib/update-notifier/apt-check --human-readable
echo -e "###########################################\n"
# Installing all esm-infra packages
lxc exec $name -- sudo apt-get upgrade -y > /dev/null
# Disabling esm-infra
lxc exec $name -- sudo pro disable esm-infra > /dev/null
echo "* Updated update-notifier message with esm-infra disabled"
echo "###########################################"
lxc exec $name -- /usr/lib/update-notifier/apt-check --human-readable
echo -e "###########################################\n"
cleanup
-----------------------------------------------------
Notice that you need a UA token to run this script.
Additionally, most messages will appear on the xenial machine due to it being ESM already
[Regression Potential]
We are just providing message changes, so the regression potential is really low. User might notice the changes, but they are not that different from the original ones.
Like in bug 1980368, translatable strings are affected, but we accept
them for the same reason as we did in that bug.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1991030/+subscriptions
More information about the foundations-bugs
mailing list