[Bug 1833863] Re: Incorrect logic for <Merge type="all">

[Sean Davis]

** Bug watch added: gitlab.xfce.org/xfce/garcon/-/issues #32
   https://gitlab.xfce.org/xfce/garcon/-/issues/32

** Also affects: garcon via
   https://gitlab.xfce.org/xfce/garcon/-/issues/32
   Importance: Unknown
       Status: Unknown

** Changed in: garcon (Ubuntu)
       Status: New => Triaged

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to pyxdg in Ubuntu.
https://bugs.launchpad.net/bugs/1833863

Title:
  Incorrect logic for <Merge type="all">

Status in Garcon:
  Unknown
Status in PyXDG:
  New
Status in garcon package in Ubuntu:
  Triaged
Status in pyxdg package in Ubuntu:
  New
Status in xubuntu-default-settings package in Ubuntu:
  Fix Released

Bug description:
  XFCE & Xubuntu use <Merge type="all" /> in their menu files, which
  python-xdg currently (all current versions) does not handle correctly:

  https://gitlab.freedesktop.org/xdg/pyxdg/issues/12

  I think the fix is as simple as

  --- Menu.py.a   2019-06-23 17:44:24.992850139 +0100
  +++ Menu.py.b   2019-06-23 17:44:41.052807584 +0100
  @@ -997,7 +997,7 @@
                   for menuentry in menu.MenuEntries:
                       if menuentry not in tmp_e:
                           menu.Entries.append(menuentry)
  -            elif order[1] == "menus" or order[1] == "all":
  +            if order[1] == "menus" or order[1] == "all":
                   menu.Submenus.sort()
                   for submenu in menu.Submenus:
                       if submenu.Name not in tmp_s:

  But as it can also be trivially worked around by replacing <Merge
  type="all" /> with <Merge type="menus" /><Merge type="files" />, I
  wonder if this should be done in XFCE/Xubuntu?

To manage notifications about this bug go to:
https://bugs.launchpad.net/garcon/+bug/1833863/+subscriptions