[Bug 1962454] Re: Oops pages show wrong time window in JournalErrors

[Benjamin Drung]

Tested on focal. Test script:

```
#!/bin/sh
set -u

log() {
	local msg="$1"
	echo "I: $msg"
	sudo sh -c "echo '$msg' > /dev/kmsg"
}

sudo rm /var/crash/*

date
log "some messages"
sleep 1
log "more messages"
sleep 3600 &
killall -11 sleep
log 'message after crash'
sleep 5
log 'message 5 seconds after crash'
sleep 10
log 'message 10 seconds after crash'
```

Steps:
* Run the test script
* Close the Apport crash window
* Wait > 10 seconds
* `ubuntu-bug /var/crash/_usr_bin_sleep.1000.crash`

Verified 2.20.11-0ubuntu27.25 for focal:
https://errors.ubuntu.com/oops/b6e647e1-6a79-11ed-a977-fa163e55efd0

** Tags removed: verification-needed verification-needed-focal
** Tags added: verification-done verification-done-focal

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1962454

Title:
  Oops pages show wrong time window in JournalErrors

Status in Apport:
  Fix Released
Status in apport package in Ubuntu:
  Fix Released
Status in apport source package in Focal:
  Fix Committed
Status in apport source package in Jammy:
  Fix Committed

Bug description:
  [Impact]

  Oops pages show wrong time window in JournalErrors. For example, I
  just experienced a crash at:

    Feb 28 17:31:12

  And the JournalErrors entries are:

    Feb 28 17:31:30 - Feb 28 17:31:41

  So don't relate to the crash.

  [Test Plan]

  1. Find a recent crash report from a relevant Ubuntu release on
  https://errors.ubuntu.com/ If you're looking at
  https://errors.ubuntu.com/problem/SOMETHING then scroll down and pick
  a relevant instance from the Occurrences list.

  2. Now you're on a page starting with https://errors.ubuntu.com/oops/
  look at ApportVersion and verify that apport is a recent enough
  version to contain the proposed fix. If not then go to step 1.

  3. Verify the Date field falls within the time range of the
  JournalErrors entries.

  Step 3 might fail in the case of there being no system log entries
  from around the time of the crash. That does not necessarily mean the
  test plan has failed. Go to step 1 and pick a different crash.

  Prior to the fix you would almost never find oops pages that would
  pass the test. After the fix you should find many/most oops pages do
  pass the test.

  [Where problems could occur]

  Worst case - in any part of the bug reporting/collection procedure,
  since that is what's changing.

  [Other Info]

  Due to the huge amount of broken autopkgtest tests, the diff for the
  SRUs are bigger than desired. The individual commits in
  https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/apport/ are
  probably easier to review.

  * jammy SRU: https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/apport/log/?h=1fa042cc27714c407494b3d6dfd0730bb984f3eb
  * focal SRU: https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/apport/log/?h=eaa92037c7dfba621719c6f81fd75f6a09e90881

To manage notifications about this bug go to:
https://bugs.launchpad.net/apport/+bug/1962454/+subscriptions