[Bug 1980929] Re: Allow to bypass container exit test

[Łukasz Zemczak]

** Also affects: livecd-rootfs (Ubuntu)
   Importance: Undecided
       Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to flash-kernel in Ubuntu.
https://bugs.launchpad.net/bugs/1980929

Title:
  Allow to bypass container exit test

Status in flash-kernel package in Ubuntu:
  New
Status in livecd-rootfs package in Ubuntu:
  New
Status in flash-kernel source package in Jammy:
  New
Status in livecd-rootfs source package in Jammy:
  New
Status in flash-kernel source package in Kinetic:
  New
Status in livecd-rootfs source package in Kinetic:
  New

Bug description:
  https://bugs.launchpad.net/ubuntu/+source/flash-kernel/+bug/1863145
  introduced a test at the beginning of main() to skip flash-kernel
  completely if we are in a container: that logic breaks the creation of
  RISC-V images where we need flash-kernel to run in order to install
  the dtb at the right location for update-grub.

  So introduce a new environment variable that allows to bypass this
  test in such circumstances: FK_FORCE_CONTAINER must be equal to "yes"
  to skip the test and allow flash-kernel to run.

  [Impact]

  RISC-V images build needs to run flash-kernel to install the dtb for
  update-grub to find. Currently, Ubuntu has a delta that prevents
  flash-kernel to run in a container but our infrastructure runs the
  images build inside a container which breaks the installation of the
  dtb on RISC-V images.

  We fix this by adding a new environment variable which will be set to
  "yes" only when building a RISC-V image.

  [Test Plan]

  To reproduce this bug, we only need to launch livecd-rootfs inside a
  LXC container.

  To test this fix, I'll patch livecd-rootfs in order to set the new
  environment variable and we'll trigger a new build of a RISC-V image
  from launchpad.

  [Where problems could occur]

  We must take care at not breaking other images builds, or boot on the
  cloud images (the reason for initial introduction of the container
  test in LP: #1863145), so great attention to the patch must be paid so
  that it only changes the current behaviour when we set the environment
  variable. The chosen variable name is specific enough as it likely
  won't be used (i.e.: FK_FORCE_CONTAINER).

  [Other Info]

  This patch is needed in Jammy as we intend to publish new RISC-V
  images for 22.04.1.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/flash-kernel/+bug/1980929/+subscriptions