[Bug 1960537] Please test proposed package

[Steve Langasek]

Hello John, or anyone else affected,

Accepted livecd-rootfs into focal-proposed. The package will build now
and be available at https://launchpad.net/ubuntu/+source/livecd-
rootfs/2.664.38 in a few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
focal to verification-done-focal. If it does not fix the bug for you,
please add a comment stating that, and change the tag to verification-
failed-focal. In either case, without details of your testing we will
not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: livecd-rootfs (Ubuntu Bionic)
       Status: New => Fix Committed

** Tags added: verification-needed-bionic

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to livecd-rootfs in Ubuntu.
https://bugs.launchpad.net/bugs/1960537

Title:
  umount_partition e2fsck call fails with ${rootfs_dev_mapper} in use

Status in livecd-rootfs package in Ubuntu:
  Fix Committed
Status in livecd-rootfs source package in Bionic:
  Fix Committed
Status in livecd-rootfs source package in Focal:
  Fix Committed
Status in livecd-rootfs source package in Impish:
  Fix Committed
Status in livecd-rootfs source package in Jammy:
  Fix Committed

Bug description:
  When running builds locally or within launchpad, cloud-images are
  starting to fail in many places with the following error:

  ```
  + udevadm settle
  + '[' -n /dev/mapper/loop0p1 -a -b /dev/mapper/loop0p1 ']'
  + '[' -e /etc/mtab ']'
  + e2fsck -y -E discard /dev/mapper/loop0p1
  e2fsck 1.45.5 (07-Jan-2020)
  /dev/mapper/loop0p1 is in use.
  e2fsck: Cannot continue, aborting.
  ```

  This call happens on calls to `umount_disk_image` which then calls
  `umount_partition`.

  `dmsetup info` reports (as an example)

  ```
  Name:              loop3p1
  State:             ACTIVE
  Read Ahead:        256
  Tables present:    LIVE
  Open count:        1
  Event number:      0
  Major, minor:      253, 0
  Number of targets: 1
  UUID: part1-devnode_7:3_Wh5pYvM
  ```

  This shows that there's an open file handle on loop3p1.

  This was first noticed in Jammy builds. After a fair amount of
  debugging by jchittum, no root cause was found. However, a workaround
  was added to the failing CPC hook:

  sleep 30

  Trial and error found that shorter sleeps still failed.

  Due to the ephemeral nature, I [jchittum] have been unable to find a
  root cause. The file handle cleans itself up quickly enough that even
  when I'm on a node watching the build, I haven't been able to track
  down an exact cause due to the handle releasing in a short time.

  [Test case]
  The autopkgtests should continue to pass.
  For focal, the daily image builds should continue to pass.
  For all series, the CPC team will need to confirm that this has not regressed their builds, as they downstream from the livecd-rootfs in the archive using cloud sauce scripts.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/livecd-rootfs/+bug/1960537/+subscriptions