[Bug 1996477] Re: [UBUNTU 22.04] dbginfo.sh updates for /bin/dash shell compatibility

[Frank Heimes]

I successfully verified the packages s390-tools*3.2_s390x.deb on jammy
(see attachment).

Hence updating the tag accordingly ...

** Attachment added: "verification_jammy.txt"
   https://bugs.launchpad.net/ubuntu/+source/s390-tools/+bug/1996477/+attachment/5633880/+files/verification_jammy.txt

** Tags removed: verification-needed-jammy
** Tags added: verification-done-jammy

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to s390-tools in Ubuntu.
https://bugs.launchpad.net/bugs/1996477

Title:
  [UBUNTU 22.04] dbginfo.sh updates for /bin/dash shell compatibility

Status in Ubuntu on IBM z Systems:
  In Progress
Status in s390-tools package in Ubuntu:
  Invalid
Status in s390-tools source package in Jammy:
  Fix Committed
Status in s390-tools source package in Kinetic:
  Fix Committed
Status in s390-tools source package in Lunar:
  Invalid

Bug description:
  SRU Justification:
  ==================

  [ Impact ]

   * The dbginfo.sh script fails on system (actually shells) that run dash,
     due to some incompatibilities in dbginfo.sh (with using 'type').

   * The script fails with a with parameter error.

  [ Fixes ]

   * 92b84092 92b84092077f5238f8067f24e9fc330ddefb4525 "dbginfo.sh:
  ensure type commands compatible with dash"

   * 9f93af61 9f93af614f7463317ec56af5a6484f66386af797 "dbginfo.sh:
  ensure compatibility with /bin/dash"

  [ Test Plan ]

   * Use a user account that has dash as default shell,
     or simply call dash in whatever shell you are running.

   * Make sure the s390-tools are installed (but it's mandatory for s390x)
     since dbginfo.sh is included into this.

   * Now call /usr/sbin/dbginfo.sh (from within a dash shell)
     and watch out for any errors,
     esp. some caused by issues with parameters,
     like 'type' is not supporting '-t'.

  [ Where problems could occur ]

   * The changes in handling the parameters could break the dbginfo.sh
     on other shells, like bash (which is the default in Ubuntu).

   * Fortunately the changes in the above commits are pretty traceable.

  __________

  Description:   dbginfo.sh: incompatible commands with /bin/dash shell
  Symptom:       subsection data collection fails while running in /bin/dash shell
                 - type is failing with parameter error

  Problem:       reduced data collection
  Solution:      rewrite in compatible way
  Component:     s390-tools

  the master commits in s390tools v2.24.9 are:

  92b8409 92b84092077f5238f8067f24e9fc330ddefb4525 "dbginfo.sh: ensure
  type commands compatible with dash"

  9f93af6 9f93af614f7463317ec56af5a6484f66386af797 "dbginfo.sh: ensure
  compatibility with /bin/dash"

  source:
  https://github.com/ibm-s390-linux/s390-tools/blob/master/scripts/dbginfo.sh

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1996477/+subscriptions