[Bug 1995294] Re: rmdir: failed to remove '/etc/systemd/system/ssh.socket.d': Directory not empty

[Launchpad Bug Tracker]

This bug was fixed in the package openssh - 1:9.0p1-1ubuntu8

---------------
openssh (1:9.0p1-1ubuntu8) lunar; urgency=medium

  * debian/openssh-server.postinst: Fix handling of ListenAddress when a port
    is specified (LP: #1993478):
    - Strip port before converting hostnames to numerical addresses.
    - Only append ports when the ListenAddress does not already specify a
      port.
    - Revert socket migration on upgrade if a previous version did the
      migration when it should not have.
  * debian/openssh-server.postinst: Ignore empty directory failure from rmdir
    when skipping socket migration (LP: #1995294).

 -- Nick Rosbrook <nick.rosbrook at canonical.com>  Tue, 25 Oct 2022
11:57:43 -0400

** Changed in: openssh (Ubuntu)
       Status: Triaged => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to openssh in Ubuntu.
https://bugs.launchpad.net/bugs/1995294

Title:
  rmdir: failed to remove '/etc/systemd/system/ssh.socket.d': Directory
  not empty

Status in openssh package in Ubuntu:
  Fix Released
Status in openssh source package in Kinetic:
  Fix Released

Bug description:
  [Impact]

  If a user a has an existing drop-in config for ssh.socket in
  /etc/systemd/system/ssh.socket.d upgrades to kinetic, and openssh-
  server.postint determines it should *not* perform migration to socket-
  activated ssh, they will receive an error from dpkg:

  Errors were encountered while processing:
   openssh-server
  Exception during pm.DoInstall():  E:Sub-process /usr/bin/dpkg returned an error code (1)

  Could not install the upgrades

  The upgrade has aborted. Your system could be in an unusable state. A 
  recovery will run now (dpkg --configure -a). 

  Please report this bug in a browser at 
  http://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+filebug 
  and attach the files in /var/log/dist-upgrade/ to the bug report. 
  E:Sub-process /usr/bin/dpkg returned an error code (1) 

  Setting up openssh-server (1:9.0p1-1ubuntu7) ...
  rmdir: failed to remove '/etc/systemd/system/ssh.socket.d': Directory not empty
  dpkg: error processing package openssh-server (--configure):
   installed openssh-server package post-installation script subprocess returned error exit status 1
  Errors were encountered while processing:
   openssh-server

  [Test Plan]

  * On a Jammy machine, install openssh-server if necessary. Edit
  /etc/ssh/sshd_config to contain the following:

  $ cat /etc/ssh/sshd_config
  [... defaults everywhere else ...]

  #Port 22
  #AddressFamily any
  ListenAddress 0.0.0.0
  ListenAddress ::

  [... defaults everywhere else ...]

  * Create a trivial drop-in override for ssh.socket:

  $ systemctl edit ssh.socket
  $ cat /etc/systemd/system/ssh.socket.d/override.conf 
  [Unit]
  Description=Testing

  * Now perform an upgrade to Kinetic, and observe the dpkg error.

  [Where problems could occur]
  The solution should be to use rmdir's --ignore-fail-on-empty flag. If the flag was mis-spelled, that would produce a new error.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/openssh/+bug/1995294/+subscriptions