[Bug 1980334] Re: Support Quectel's modem(EM120/160) firmware update, fwupd

[Mario Limonciello]

YC - here's my feedback:

Focal
-----
1) I think this bug report will need tasks and test cases for focal for G-S and G-F considering the rebuild.
2) I expect #1966364 is to be fixed as well, you should add to changelog
3) Please double check if #1969976 happens.  I think it should be fixed already, but if it's not then there is a slight packaging change that should cherry-pick and I can help you identify it for 1.7.9.
4) Isn't #1982103 fixed for Focal too?
https://github.com/fwupd/fwupd/commit/b2aaddabe456e1a19bc21fd531b84c170507aba5 is part of 1.7.9

Jammy
-----
Some minor typos in changelog.  Please fix those up and I'll check it one more time and sponsor it.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to libxmlb in Ubuntu.
Matching subscriptions: foundations-bugs-libxmlb
https://bugs.launchpad.net/bugs/1980334

Title:
  Support Quectel's modem(EM120/160) firmware update, fwupd

Status in OEM Priority Project:
  In Progress
Status in fwupd package in Ubuntu:
  Fix Released
Status in libxmlb package in Ubuntu:
  Fix Released
Status in fwupd source package in Focal:
  In Progress
Status in libxmlb source package in Focal:
  In Progress
Status in fwupd source package in Kinetic:
  Fix Released
Status in libxmlb source package in Kinetic:
  Fix Released

Bug description:
  [Impact]

   * EM120/160 firmware update's fw can't get updated.

  [Test Plan]

   * Use a machine with EM120/160 and test fw upgrade or reinstall.

  For the rest of the SRU document, please check lp:1982103

    --

  
  The current fwupd packages in focal have to be rebuild with the latest 1.18.6 modem manager[1] in updates channel.

  In the modem-manager plugin of fwupd, there are several version check
  macros to determine the version of modem-manager, for instance:

  https://git.launchpad.net/ubuntu/+source/fwupd/tree/plugins/modem-
  manager/fu-mm-device.c?h=ubuntu/focal-updates#n22

      #if MM_CHECK_VERSION(1, 17, 2)
      #include "fu-firehose-updater.h"
      #endif

  If the version is equal to or newer than 1.17.2, fwupd will have
  different behaviors. And the previous version in Focal is 1.16.6 so we
  have to rebuild or do a version bump to make sure it compile with the
  new modem manager.

  [1]
  https://launchpad.net/ubuntu/+source/modemmanager/1.18.6-1~ubuntu20.04.1

To manage notifications about this bug go to:
https://bugs.launchpad.net/oem-priority/+bug/1980334/+subscriptions