[Bug 1968607] Re: screen became locked during release upgrade

Nick Rosbrook 1968607 at bugs.launchpad.net
Thu Apr 14 14:20:14 UTC 2022 

** Description changed:

+ [Impact]
+ 
+ This bug prevents the screen lock inhibitor logic when the Gtk3 or KDE
+ frontends are used for release upgrades. This leaves users at risk of
+ encountering an issue where the lock screen cannot be unlocked, if it was
+ locked during upgrade.
+ 
+ This is needed in the stable releases because it affects upgrades to
+ jammy.
+ 
+ [Test Plan]
+ 
+ To reproduce on impish, do the following:
+ 
+ * For ease of testing, set your screen lock timeout to 1 minute.
+ * Start an upgrade to jammy using the Gtk3 frontend:
+ 
+   $ do-release-upgrade -d -f DistUpgradeViewGtk3
+ 
+ * Click the 'Upgrade' button when the release notes are displayed. When
+   prompted, click 'Start Upgrade'. Observe that there is no information message
+   indicating the screen lock has been disabled (nor is there a message
+   indicating that we failed to disable the screen lock).
+ * Idle long enough to allow the screen lock to kick in.
+ 
+ Note: dbus-monitor "interface=org.freedesktop.ScreenSaver" can also be used to
+ monitor any attempts to disable the screen lock.
+ 
+ [Where problems could occur]
+ 
+ This patch introduces new environment variables to the upgrade that were not
+ previously set when the KDE or Gtk3 frontends were used. Regressions could
+ occur if any existing code (besides the screen lock inhibitor code) had
+ different behavior based on these variables.
+ 
+ [Original Description]
+ 
  I was upgrading from Ubuntu 21.10 to Ubuntu 22.04 this morning when my
  lock screen became enabled. My screen is set to blank after 5 minutes.
  Looking at the main release upgrade log file I noticed the following:
  
  2022-04-11 06:55:10,389 INFO release-upgrader version '22.04.7' started
  ...
  2022-04-11 06:58:10,297 DEBUG inhibit screensaver
  
  Then in /var/log/auth.log I found:
  
  Apr 11 07:06:24 godspeed gdm-password]: gkr-pam: unlocked login keyring
  
  I don't recall when I last responded to a dialog from ubuntu-release-
  upgrader but I would guess it was around here:
  
  2022-04-11 06:56:18,259 DEBUG About to apply the following changes
  
  So that would only be a couple of minutes of inactivity before the
  screensaver was inhibited, so I don't think it worked. Additionally, I
  never saw a message about the screen lock being disabled.
  
  ProblemType: Bug
  DistroRelease: Ubuntu 22.04
  Package: ubuntu-release-upgrader-core 1:22.04.8
  ProcVersionSignature: Ubuntu 5.15.0-25.25-generic 5.15.30
  Uname: Linux 5.15.0-25-generic x86_64
  ApportVersion: 2.20.11-0ubuntu80
  Architecture: amd64
  CasperMD5CheckResult: pass
  CrashDB: ubuntu
  CurrentDesktop: ubuntu:GNOME
  Date: Mon Apr 11 11:07:56 2022
  InstallationDate: Installed on 2022-01-07 (94 days ago)
  InstallationMedia: Ubuntu 21.10 "Impish Indri" - Release amd64 (20211012)
  PackageArchitecture: all
  SourcePackage: ubuntu-release-upgrader
  Symptom: ubuntu-release-upgrader
  UpgradeStatus: Upgraded to jammy on 2022-04-11 (0 days ago)
  VarLogDistupgradeTermlog:

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubuntu-release-upgrader in
Ubuntu.
https://bugs.launchpad.net/bugs/1968607

Title:
  screen became locked during release upgrade

Status in ubuntu-release-upgrader package in Ubuntu:
  Fix Released
Status in ubuntu-release-upgrader source package in Focal:
  Triaged
Status in ubuntu-release-upgrader source package in Impish:
  Triaged
Status in ubuntu-release-upgrader source package in Jammy:
  Fix Released

Bug description:
  [Impact]

  This bug prevents the screen lock inhibitor logic when the Gtk3 or KDE
  frontends are used for release upgrades. This leaves users at risk of
  encountering an issue where the lock screen cannot be unlocked, if it was
  locked during upgrade.

  This is needed in the stable releases because it affects upgrades to
  jammy.

  [Test Plan]

  To reproduce on impish, do the following:

  * For ease of testing, set your screen lock timeout to 1 minute.
  * Start an upgrade to jammy using the Gtk3 frontend:

    $ do-release-upgrade -d -f DistUpgradeViewGtk3

  * Click the 'Upgrade' button when the release notes are displayed. When
    prompted, click 'Start Upgrade'. Observe that there is no information message
    indicating the screen lock has been disabled (nor is there a message
    indicating that we failed to disable the screen lock).
  * Idle long enough to allow the screen lock to kick in.

  Note: dbus-monitor "interface=org.freedesktop.ScreenSaver" can also be used to
  monitor any attempts to disable the screen lock.

  [Where problems could occur]

  This patch introduces new environment variables to the upgrade that were not
  previously set when the KDE or Gtk3 frontends were used. Regressions could
  occur if any existing code (besides the screen lock inhibitor code) had
  different behavior based on these variables.

  [Original Description]

  I was upgrading from Ubuntu 21.10 to Ubuntu 22.04 this morning when my
  lock screen became enabled. My screen is set to blank after 5 minutes.
  Looking at the main release upgrade log file I noticed the following:

  2022-04-11 06:55:10,389 INFO release-upgrader version '22.04.7' started
  ...
  2022-04-11 06:58:10,297 DEBUG inhibit screensaver

  Then in /var/log/auth.log I found:

  Apr 11 07:06:24 godspeed gdm-password]: gkr-pam: unlocked login
  keyring

  I don't recall when I last responded to a dialog from ubuntu-release-
  upgrader but I would guess it was around here:

  2022-04-11 06:56:18,259 DEBUG About to apply the following changes

  So that would only be a couple of minutes of inactivity before the
  screensaver was inhibited, so I don't think it worked. Additionally, I
  never saw a message about the screen lock being disabled.

  ProblemType: Bug
  DistroRelease: Ubuntu 22.04
  Package: ubuntu-release-upgrader-core 1:22.04.8
  ProcVersionSignature: Ubuntu 5.15.0-25.25-generic 5.15.30
  Uname: Linux 5.15.0-25-generic x86_64
  ApportVersion: 2.20.11-0ubuntu80
  Architecture: amd64
  CasperMD5CheckResult: pass
  CrashDB: ubuntu
  CurrentDesktop: ubuntu:GNOME
  Date: Mon Apr 11 11:07:56 2022
  InstallationDate: Installed on 2022-01-07 (94 days ago)
  InstallationMedia: Ubuntu 21.10 "Impish Indri" - Release amd64 (20211012)
  PackageArchitecture: all
  SourcePackage: ubuntu-release-upgrader
  Symptom: ubuntu-release-upgrader
  UpgradeStatus: Upgraded to jammy on 2022-04-11 (0 days ago)
  VarLogDistupgradeTermlog:

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1968607/+subscriptions

More information about the foundations-bugs mailing list