[Bug 1968205] [NEW] errors with mult-volume gadgets

[William Wilson]

Public bug reported:

The logic is subtly different in the Python and Go versions of ubuntu-
image for populating bootfs contents. With multi volume gadgets, only
the system volume is processed by this function. This needs to be fixed
and tested with the following gadget.yaml:

```
volumes:
  pc:
    # bootloader configuration is shipped and managed by snapd
    bootloader: grub
    structure:
      - name: mbr
        type: mbr
        size: 440
        update:
          edition: 1
        content:
          - image: pc-boot.img
      - name: BIOS Boot
        type: DA,21686148-6449-6E6F-744E-656564454649
        size: 1M
        offset: 1M
        offset-write: mbr+92
        update:
          edition: 2
        content:
          - image: pc-core.img
      - name: ubuntu-seed
        role: system-seed
        filesystem: vfat
        # UEFI will boot the ESP partition by default first
        type: EF,C12A7328-F81F-11D2-BA4B-00A0C93EC93B
        size: 1200M
        update:
          edition: 2
        content:
          - source: grubx64.efi
            target: EFI/boot/grubx64.efi
          - source: shim.efi.signed
            target: EFI/boot/bootx64.efi
      - name: ubuntu-boot
        role: system-boot
        filesystem: ext4
        type: 83,0FC63DAF-8483-4772-8E79-3D69D8477DE4
        # whats the appropriate size?
        size: 750M
        update:
          edition: 1
        content:
          - source: grubx64.efi
            target: EFI/boot/grubx64.efi
          - source: shim.efi.signed
            target: EFI/boot/bootx64.efi
      - name: ubuntu-save
        role: system-save
        filesystem: ext4
        type: 83,0FC63DAF-8483-4772-8E79-3D69D8477DE4
        size: 16M
      - name: ubuntu-data
        role: system-data
        filesystem: ext4
        type: 83,0FC63DAF-8483-4772-8E79-3D69D8477DE4
        size: 2G
  foo:
    structure:
      - name: barething
        type: bare
        size: 4096
        content:
          - image: foobare.img
      - name: no-fs-partition
        type: 84,A11D2A7C-D82A-4C2F-8A01-1805240E6626
        size: 4096
        content:
          - image: foowithoutfs.img
      - name: some-filesystem
        filesystem: ext4
        type: 83,0FC63DAF-8483-4772-8E79-3D69D8477DE4
        size: 100M
        content:
          - source: foo.txt
            target: foo.txt
      - name: foounspecifiedfs
        type: 83,0FC63DAF-8483-4772-8E79-3D69D8477DE4
        size: 100M
        content:
          - image: foowithfs-v1.img
```

** Affects: ubuntu-image
     Importance: Undecided
         Status: New

** Affects: ubuntu-image (Ubuntu)
     Importance: Undecided
         Status: New

** Also affects: ubuntu-image (Ubuntu)
   Importance: Undecided
       Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubuntu-image in Ubuntu.
https://bugs.launchpad.net/bugs/1968205

Title:
  errors with mult-volume gadgets

Status in Ubuntu Image:
  New
Status in ubuntu-image package in Ubuntu:
  New

Bug description:
  The logic is subtly different in the Python and Go versions of ubuntu-
  image for populating bootfs contents. With multi volume gadgets, only
  the system volume is processed by this function. This needs to be
  fixed and tested with the following gadget.yaml:

  ```
  volumes:
    pc:
      # bootloader configuration is shipped and managed by snapd
      bootloader: grub
      structure:
        - name: mbr
          type: mbr
          size: 440
          update:
            edition: 1
          content:
            - image: pc-boot.img
        - name: BIOS Boot
          type: DA,21686148-6449-6E6F-744E-656564454649
          size: 1M
          offset: 1M
          offset-write: mbr+92
          update:
            edition: 2
          content:
            - image: pc-core.img
        - name: ubuntu-seed
          role: system-seed
          filesystem: vfat
          # UEFI will boot the ESP partition by default first
          type: EF,C12A7328-F81F-11D2-BA4B-00A0C93EC93B
          size: 1200M
          update:
            edition: 2
          content:
            - source: grubx64.efi
              target: EFI/boot/grubx64.efi
            - source: shim.efi.signed
              target: EFI/boot/bootx64.efi
        - name: ubuntu-boot
          role: system-boot
          filesystem: ext4
          type: 83,0FC63DAF-8483-4772-8E79-3D69D8477DE4
          # whats the appropriate size?
          size: 750M
          update:
            edition: 1
          content:
            - source: grubx64.efi
              target: EFI/boot/grubx64.efi
            - source: shim.efi.signed
              target: EFI/boot/bootx64.efi
        - name: ubuntu-save
          role: system-save
          filesystem: ext4
          type: 83,0FC63DAF-8483-4772-8E79-3D69D8477DE4
          size: 16M
        - name: ubuntu-data
          role: system-data
          filesystem: ext4
          type: 83,0FC63DAF-8483-4772-8E79-3D69D8477DE4
          size: 2G
    foo:
      structure:
        - name: barething
          type: bare
          size: 4096
          content:
            - image: foobare.img
        - name: no-fs-partition
          type: 84,A11D2A7C-D82A-4C2F-8A01-1805240E6626
          size: 4096
          content:
            - image: foowithoutfs.img
        - name: some-filesystem
          filesystem: ext4
          type: 83,0FC63DAF-8483-4772-8E79-3D69D8477DE4
          size: 100M
          content:
            - source: foo.txt
              target: foo.txt
        - name: foounspecifiedfs
          type: 83,0FC63DAF-8483-4772-8E79-3D69D8477DE4
          size: 100M
          content:
            - image: foowithfs-v1.img
  ```

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-image/+bug/1968205/+subscriptions