[Bug 1925507] Proposed package upload rejected

[Steve Langasek]

An upload of grub2 to bionic-proposed has been rejected from the upload
queue for the following reason: "The debdiff for this is a mess, there
is delta to all the packages under debian/patches, impossible to review;
please reupload without the extra delta".

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to grub2 in Ubuntu.
https://bugs.launchpad.net/bugs/1925507

Title:
  grub-common: snapd autopkgtests fail on s390x

Status in snapd:
  Invalid
Status in grub2 package in Ubuntu:
  Fix Released
Status in grub2 source package in Focal:
  Fix Released

Bug description:
  [Impact]
  Probably regression from #1901553, failing to install on s390x, info below.

  [Test plan]
  Just ensure those tests don't fail like that

  [Regression potential]
  grub units only start when /boot is mounted now, as they require /boot/grub/grub.cfg to exist. Should be fine, but might not start if boot failed to mount for some reason.

  [Original bug report]
  Snapd autopkgtests depend on grub-common:

  debian/tests/control:
  Depends: @builddeps@

  debian/control:
  Build-Depends:
  ...
  grub-common,
  ...

  but grub-common fails to install on s390x, consequently snapd
  autopkgtests fall apart on s390x.

  Full log:

  https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-
  hirsute-canonical-kernel-team-
  unstable/hirsute/s390x/s/snapd/20210422_080633_56960@/log.gz

  ```
  Setting up grub-common (2.04-1ubuntu45) ...
  Created symlink /etc/systemd/system/multi-user.target.wants/grub-common.service → /lib/systemd/system/grub-common.service.
  Created symlink /etc/systemd/system/multi-user.target.wants/grub-initrd-fallback.service → /lib/systemd/system/grub-initrd-fallback.service.
  Created symlink /etc/systemd/system/rescue.target.wants/grub-initrd-fallback.service → /lib/systemd/system/grub-initrd-fallback.service.
  Created symlink /etc/systemd/system/emergency.target.wants/grub-initrd-fallback.service → /lib/systemd/system/grub-initrd-fallback.service.
  Job for grub-initrd-fallback.service failed because the control process exited with error code.
  See "systemctl status grub-initrd-fallback.service" and "journalctl -xe" for details.
  update-rc.d: warning: start and stop actions are no longer supported; falling back to defaults
  Job for grub-common.service failed because the control process exited with error code.
  See "systemctl status grub-common.service" and "journalctl -xe" for details.
  invoke-rc.d: initscript grub-common, action "start" failed.
  ● grub-common.service - Record successful boot for GRUB
       Loaded: loaded (]8;;file://autopkgtest/lib/systemd/system/grub-common.service/lib/systemd/system/grub-common.service]8;;; enabled; vendor preset: enabled)
       Active: failed (Result: exit-code) since Thu 2021-04-22 08:06:10 UTC; 8ms ago
      Process: 3111 ExecStartPre=/bin/sh -c [ -s /boot/grub/grubenv ] || rm -f /boot/grub/grubenv; mkdir -p /boot/grub (code=exited, status=0/SUCCESS)
      Process: 3114 ExecStart=grub-editenv /boot/grub/grubenv unset recordfail (code=exited, status=1/FAILURE)
      Process: 3115 ExecStartPost=/bin/sh -c if grub-editenv /boot/grub/grubenv list | grep -q initrdless_boot_fallback_triggered=1; then echo "grub: GRUB_FORCE_PARTUUID set, initrdless boot paniced, fallback triggered."; fi (code=exited, status=0/SUCCESS)
     Main PID: 3114 (code=exited, status=1/FAILURE)

  Apr 22 08:06:10 autopkgtest systemd[1]: Starting Record successful boot for GRUB...
  Apr 22 08:06:10 autopkgtest grub-editenv[3114]: grub-editenv: error: cannot rename the file /boot/grub/grubenv.new to /boot/grub/grubenv.
  Apr 22 08:06:10 autopkgtest systemd[1]: grub-common.service: Main process exited, code=exited, status=1/FAILURE
  Apr 22 08:06:10 autopkgtest systemd[1]: grub-common.service: Failed with result 'exit-code'.
  Apr 22 08:06:10 autopkgtest systemd[1]: Failed to start Record successful boot for GRUB.
  dpkg: error processing package grub-common (--configure):
   installed grub-common package post-installation script subprocess returned error exit status 1
  ```

To manage notifications about this bug go to:
https://bugs.launchpad.net/snapd/+bug/1925507/+subscriptions