[Bug 1943816] Re: "ubuntu-drivers install" needs to be used when installing nvidia-driver if enabling "third-party packages"

[jeremyszu]

Tested on impish 10/11 daily build
$ sha256sum ~/Downloads/impish-desktop-amd64.iso 
b498e92cbc97b8afa1a8a3e92fc87f8124c498500af2c4ca4b55fba4da33d5fe  /home/jeremysu/Downloads/impish-desktop-amd64.iso

The ubiquity doesn't call `ubunut-drivers install` to install (at least)
nvidia drivers but workaround by copying configurations[1].

It's because calling the "ubuntu-drivers install" might be an unexpected
call flow (calls "ubuntu-drivers install" in chroot stage of ubiquity)
and the solution may need to change a lot[2]. To implement it will be
better in coming release and workaround (by copying configurations) in
previous releases.

However, to use "ubuntu-drivers install" is the correct/final way to
make sure the logic of selecting/configuring the configurations for
proprietary drivers.

I'll suggest to have "ggg/impish/hirsute/focal" series here to make sure
we have solution(workaround) for each series (workaround in I/H/F and
have the final solution in "ggg(22.04)").

[1] https://github.com/tseliot/ubuntu-drivers-common/blob/master/ubiquity/target-config/31ubuntu_driver_packages#L12
[2] https://chat.canonical.com/canonical/pl/4juqh1kjj7b3fqusznurau4baa

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubiquity in Ubuntu.
https://bugs.launchpad.net/bugs/1943816

Title:
  "ubuntu-drivers install" needs to be used when installing nvidia-
  driver if enabling "third-party packages"

Status in OEM Priority Project:
  Confirmed
Status in ubiquity package in Ubuntu:
  New
Status in ubuntu-drivers-common package in Ubuntu:
  Fix Released

Bug description:
  ubiquity calls
  ```
  ubuntu-drivers install $FREEONLY $NOOEM --package-list /run/ubuntu-drivers.autoinstall
  ```
  to generate package list during live system but "ubuntu-drivers install" not only install packages but also create some config files for switching nvidia mode (e.g. on-demand) and change the runtime config as well (e.g. modify the iniramfs).

  Thus, not only package list needs to be referred but also the
  configuration.

  ---

  In ubuntu-drivers-common, which read the "/run/ubuntu-drivers.autoinstall" to install package. It also skipping the nvidia-mode changing (made by ubuntu-drivers install).
  ```
  $ cat ubiquity/target-config/31ubuntu_driver_packages
  #!/bin/sh
  set -e

  # install all packages that "ubuntu-drivers autoinstall" installed into the
  # live system. Ubiquity calls this with --package-list /run/ubuntu-drivers.autoinstall

  PKGLIST=/run/ubuntu-drivers.autoinstall
  [ -e $PKGLIST ] || exit 0

  for p in `cat $PKGLIST`; do
      apt-install $p
  done
  ```

  ---

  We need to use a same approach to make sure the nvidia mode is same on
  a same system (either all handing by ubuntu-drivers install or change
  the logic to maintainer script in each package).

To manage notifications about this bug go to:
https://bugs.launchpad.net/oem-priority/+bug/1943816/+subscriptions