[Bug 1951943] Re: Engine crashes when loading the configuration more than once

[Eyal Itkin]

Tested libssl1.1_1.1.1f-1ubuntu2.10_arm64.deb on an arm64 setup with
older wget installed (1.20.3-1ubuntu1), and PKA engine (1.3) configured
with debug prints.

OpenSSL indeed loaded the PKA engine only once, causing wget to work as
expected even without wget's patch against loading the engines only once
- https://bugs.launchpad.net/ubuntu/+source/wget/+bug/1921518.

I approve that this libssl package successfully addresses the engine
issue that it aims to resolve.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to openssl in Ubuntu.
https://bugs.launchpad.net/bugs/1951943

Title:
  Engine crashes when loading the configuration more than once

Status in openssl package in Ubuntu:
  Confirmed
Status in openssl source package in Bionic:
  Fix Committed
Status in openssl source package in Focal:
  Fix Committed
Status in openssl source package in Hirsute:
  Fix Committed
Status in openssl source package in Impish:
  Fix Committed
Status in openssl source package in Jammy:
  Confirmed

Bug description:
  [Impact]

   * Engine crashes when loading the configuration more than once

   * Upstream started to avoid loading engines twice by using dynamic
  ids to track the loaded engines correctly

   * OpenSSL 3
  https://github.com/openssl/openssl/commit/81c11349c2a0e945aa3dfc6bd81c957363dd2011 (bugfix)
  https://github.com/openssl/openssl/commit/38e2957249c90317a26a080c7e7eb186dd5b6598 (test case)

   * OpenSSL 1.1.1 backports:
  https://github.com/openssl/openssl/commit/9b06ebb1edfddffea083ba36090af7eb7cad207b (bugfix)
  https://github.com/openssl/openssl/pull/17083 (test case)

  [Test Plan]

   * https://github.com/openssl/openssl/issues/17023 lists multiple ways
  how one can trigger the issue at hand, but also test case implements
  this issue too by explicitly attempting to load an engine multiple
  times and checking that it is operational.

  The test a is run during the build as part of the upstream regression
  test suite, for the shared library build (as static build does not
  support engines), so you'll see one pass and one skip in the log.

  [Where problems could occur]

   * Separately we have started to fix userspace packages that
  needlessly load configuration files multiple times, which used to
  trigger this issue. The codepaths changed are with engine use, how
  they are loaded/unloaded/used. It is possible that this fix will make
  some engines to start working and be used resulting in new behaviour.
  But also exposing bugs in the engines that previously were installed &
  configured but not actually used.

  [Other Info]

   * Previous bug reports about this issues are:
  https://bugs.launchpad.net/ubuntu/+source/wget/+bug/1921518
  https://bugs.launchpad.net/ubuntu/+source/curl/+bug/1940528

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/openssl/+bug/1951943/+subscriptions