[Bug 1925529] Re: "ReleaseNotesViewer" does not display anything with the text view

[Brian Murray]

Because Impish doesn't appear in meta-release-development yet I had to
get a little creative by editing the URI for the meta-release file e.g.:

 $ head /etc/update-manager/meta-release    
# default location for the meta-release file

[METARELEASE]
#URI = https://changelogs.ubuntu.com/meta-release
URI = https://bazaar.launchpad.net/~ubuntu-core-dev/meta-release/ubuntu/download/269/meta-release
URI_LTS = https://changelogs.ubuntu.com/meta-release-lts
URI_UNSTABLE_POSTFIX = -development
URI_PROPOSED_POSTFIX = -proposed

Revision 269 had impish in m-r-d. After doing that I was able to verify
that the ReleaseAnnouncement is displayed with the version of ubuntu-
release-upgrader from -proposed. See the attached screenshot for
evidence!

** Attachment added: "bug1925529-verification.png"
   https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1925529/+attachment/5500794/+files/bug1925529-verification.png

** Tags removed: verification-needed verification-needed-hirsute
** Tags added: verification-done verification-done-hirsute

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubuntu-release-upgrader in
Ubuntu.
https://bugs.launchpad.net/bugs/1925529

Title:
  "ReleaseNotesViewer" does not display anything with the text view

Status in ubuntu-release-upgrader package in Ubuntu:
  Fix Released
Status in ubuntu-release-upgrader source package in Groovy:
  New
Status in ubuntu-release-upgrader source package in Hirsute:
  Fix Committed
Status in ubuntu-release-upgrader source package in Impish:
  Fix Released

Bug description:
  When upgrading with do-release-upgrade the ReleaseAnnouncement, e.g.
  http://archive.ubuntu.com/ubuntu/dists/hirsute/main/dist-upgrader-
  all/current/ReleaseAnnouncement, should be displayed. This works with
  DistUpgradeViewGtk3 but not DistUpgradeViewText.

  [Test Case]
  1) run 'do-release-upgrade -d -f DistUpgradeViewText' in a terminal on an Ubuntu 21.04 or Ubuntu 20.10 system
  2) you will see a sudo password prompt after the release upgrader tarball is downloaded (i.e. after the message "extracting '$nextrelease.tar.gz'")

  After installing ubuntu-release-upgrader from -proposed you'll see the
  text of the ReleaseAnnouncement before the download of the release
  upgrader tarball and a "Continue [yN]" prompt.

  Additional test:
  1) run 'do-release-upgrade -d -f DistUpgradeViewGtk3' in a terminal with the -proposed version of ubuntu-release-upgrader
  2) confirm that you don't see the ReleaseAnnouncement in the terminal

  [Where Problems Could Occur]
  This is new code in DistUpgradeFetcherCore.py for the showReleaseNotes() function. This function also exists in DistUpgradeFetcher.py so the additional code should not affect it but as a regression test "do-release-upgrade -d -f DistUpgradeViewGtk3" should also be run in a terminal to ensure that the ReleaseAnnouncement file is not shown in the terminal and in a GUI dialog.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1925529/+subscriptions