[Bug 1929449] Re: do not allow upgrades to hirsute for Apple hardware

[Brian Murray]

This quirk isn't necessary for Impish but the helper method to determine
the system vendor could be useful so that was added to
DistUpgradeQuirks.py.

https://git.launchpad.net/ubuntu-release-
upgrader/commit/?id=d125236cc2e4ec20a61f524c18b106e743355f6c

** Description changed:

  Due to LP: #1928434 release upgrades to Hirsute are not currently
  enabled for any one. However, the release upgrade process is safe for
  most systems so we should create a distribution upgrade quirk which
  prevents upgrades to Hirsute which is hardware specific.
  
  [Test Case]
  1) On Apple hardware running Ubuntu 20.10 download the release-upgrader tarball from -proposed (http://archive.ubuntu.com/ubuntu/dists/hirsute-proposed/main/dist-upgrader-all/current/hirsute.tar.gz) [This is necessary because upgrades to hirsute aren't enabled yet.]
  2) Extract the tarball
  3) Run './hirsute --frontend DistUpgradeViewGtk3'
  4) Observe a message regarding upgrades not being enabled for Apple hardware and the upgrade exit
+ 5) Run './hirsute --frontend DistUpgradeViewText' and ensure the same message appears.
  
  This should also be tested on not Apple hardware to ensure that upgrades
  can proceed for those systems.
  
  [Where Problems Could Occur]
  The _test_and_fail_on_apple() also will prevent upgrades for systems where /sys/lcass/dmi/id/sys_vendor does not exist which is a new situation. However, until the shim bug is resolved that seems like the safest option for users. After the shim bug is resolved we'll disable this specific quirk.
  
  Additionally, if the quirk is poorly written it could disallow all
  upgrades but we are testing for this by testing it on non-Apple
  hardware.

** Also affects: ubuntu-release-upgrader (Ubuntu Hirsute)
   Importance: Undecided
       Status: New

** Changed in: ubuntu-release-upgrader (Ubuntu Hirsute)
       Status: New => In Progress

** Changed in: ubuntu-release-upgrader (Ubuntu Hirsute)
     Assignee: (unassigned) => Brian Murray (brian-murray)

** Changed in: ubuntu-release-upgrader (Ubuntu Hirsute)
   Importance: Undecided => High

** Changed in: ubuntu-release-upgrader (Ubuntu)
       Status: New => Invalid

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubuntu-release-upgrader in
Ubuntu.
https://bugs.launchpad.net/bugs/1929449

Title:
  do not allow upgrades to hirsute for Apple hardware

Status in ubuntu-release-upgrader package in Ubuntu:
  Invalid
Status in ubuntu-release-upgrader source package in Hirsute:
  In Progress

Bug description:
  Due to LP: #1928434 release upgrades to Hirsute are not currently
  enabled for any one. However, the release upgrade process is safe for
  most systems so we should create a distribution upgrade quirk which
  prevents upgrades to Hirsute which is hardware specific.

  [Test Case]
  1) On Apple hardware running Ubuntu 20.10 download the release-upgrader tarball from -proposed (http://archive.ubuntu.com/ubuntu/dists/hirsute-proposed/main/dist-upgrader-all/current/hirsute.tar.gz) [This is necessary because upgrades to hirsute aren't enabled yet.]
  2) Extract the tarball
  3) Run './hirsute --frontend DistUpgradeViewGtk3'
  4) Observe a message regarding upgrades not being enabled for Apple hardware and the upgrade exit
  5) Run './hirsute --frontend DistUpgradeViewText' and ensure the same message appears.

  This should also be tested on not Apple hardware to ensure that
  upgrades can proceed for those systems.

  [Where Problems Could Occur]
  The _test_and_fail_on_apple() also will prevent upgrades for systems where /sys/lcass/dmi/id/sys_vendor does not exist which is a new situation. However, until the shim bug is resolved that seems like the safest option for users. After the shim bug is resolved we'll disable this specific quirk.

  Additionally, if the quirk is poorly written it could disallow all
  upgrades but we are testing for this by testing it on non-Apple
  hardware.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1929449/+subscriptions