[Bug 1929129] Re: if cloud-init status is not done, set_installer_password will crash

[Michael Hudson-Doyle]

** Changed in: subiquity (Ubuntu)
       Status: New => Fix Committed

** Also affects: subiquity
   Importance: Undecided
       Status: New

** Changed in: subiquity
       Status: New => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to subiquity in Ubuntu.
https://bugs.launchpad.net/bugs/1929129

Title:
  if cloud-init status is not done, set_installer_password will crash

Status in subiquity:
  Fix Committed
Status in subiquity package in Ubuntu:
  Fix Committed

Bug description:
  subiquity/server/server.py will only assign to cloud if 'status:done'
  later, if we're not in dry run, set_installer_password will attempt to use self.cloud.

  traceback

  2021-05-20 14:39:07,854 INFO subiquity:101 Starting Subiquity server revision unknown
  2021-05-20 14:39:07,854 INFO subiquity:102 Arguments passed: ['/home/marcustomlinson/Projects/flutter/ubuntu-desktop-installer/packages/subiquity_client/subiquity/subiquity/cmd/server.py']
  2021-05-20 14:39:07,854 DEBUG asyncio:59 Using selector: EpollSelector
  2021-05-20 14:39:07,855 DEBUG subiquitycore.prober:35 Prober() init finished, data:None
  2021-05-20 14:39:07,857 DEBUG curtin:87 Running command ['dpkg', '--print-architecture'] with allowed return codes [0] (capture=True)
  2021-05-20 14:39:07,866 DEBUG subiquitycore.utils:74 arun_command called: ['cloud-init', 'status', '--wait']
  2021-05-20 14:39:08,220 DEBUG subiquitycore.utils:83 arun_command ['cloud-init', 'status', '--wait'] exited with code 0
  2021-05-20 14:39:08,220 DEBUG subiquity.server.server:422 waited 0.35422635078430176s for cloud-init
  2021-05-20 14:39:08,220 DEBUG subiquity.server.server:440 cloud-init status: '\nstatus: disabled\n', assumed disabled
  2021-05-20 14:39:08,221 ERROR subiquity.server.server:324 top level error
  Traceback (most recent call last):
    File "/home/marcustomlinson/Projects/flutter/ubuntu-desktop-installer/packages/subiquity_client/subiquity/subiquity/server/server.py", line 504, in start
      self.set_installer_password()
    File "/home/marcustomlinson/Projects/flutter/ubuntu-desktop-installer/packages/subiquity_client/subiquity/subiquity/server/server.py", line 474, in set_installer_password
      self.cloud.cfg, self.cloud.distro)
  AttributeError: 'SubiquityServer' object has no attribute 'cloud'
  2021-05-20 14:39:08,221 ERROR subiquity.server.server:324 top level error
  Traceback (most recent call last):
    File "/home/marcustomlinson/Projects/flutter/ubuntu-desktop-installer/packages/subiquity_client/subiquity/subiquity/server/server.py", line 308, in _run_error_cmds
      await report._info_task
  AttributeError: 'NoneType' object has no attribute '_info_task'

To manage notifications about this bug go to:
https://bugs.launchpad.net/subiquity/+bug/1929129/+subscriptions